Update tests

Author: Ecarrion

WooCommerce/Classes/ViewModels/Order Details/OrderDetailsViewModel.swift

@@ -8,10 +8,12 @@ import Experiments
 import WooFoundation
 import SwiftUI
 import enum Networking.DotcomError
+import protocol Storage.StorageManagerType
 
 final class OrderDetailsViewModel {
 
     private let stores: StoresManager
+    private let storageManager: StorageManagerType
     private let currencyFormatter: CurrencyFormatter
 
     private(set) var order: Order
@@ -26,9 +28,11 @@ final class OrderDetailsViewModel {
 
     init(order: Order,
          stores: StoresManager = ServiceLocator.stores,
+         storageManager: StorageManagerType = ServiceLocator.storageManager,
          currencyFormatter: CurrencyFormatter = CurrencyFormatter(currencySettings: ServiceLocator.currencySettings)) {
         self.order = order
         self.stores = stores
+        self.storageManager = storageManager
         self.currencyFormatter = currencyFormatter
     }
 
@@ -663,7 +667,7 @@ extension OrderDetailsViewModel {
     ///
     private func arePluginsSynced() -> Bool {
         let predicate = NSPredicate(format: "siteID == %lld", order.siteID)
-        let resultsController = ResultsController<StorageSystemPlugin>(storageManager: ServiceLocator.storageManager, matching: predicate, sortedBy: [])
+        let resultsController = ResultsController<StorageSystemPlugin>(storageManager: storageManager, matching: predicate, sortedBy: [])
         try? resultsController.performFetch()
         return !resultsController.isEmpty
     }

WooCommerce/WooCommerceTests/ViewRelated/OrderDetailsViewModelTests.swift

@@ -9,13 +9,15 @@ final class OrderDetailsViewModelTests: XCTestCase {
     private var viewModel: OrderDetailsViewModel!
 
     private var storesManager: MockStoresManager!
+    private var storageManager: MockStorageManager!
 
     override func setUp() {
         storesManager = MockStoresManager(sessionManager: SessionManager.makeForTesting())
+        storageManager = MockStorageManager()
 
         order = MockOrders().sampleOrder()
 
-        viewModel = OrderDetailsViewModel(order: order, stores: storesManager)
+        viewModel = OrderDetailsViewModel(order: order, stores: storesManager, storageManager: storageManager)
 
         let analytics = WooAnalytics(analyticsProvider: MockAnalyticsProvider())
         ServiceLocator.setAnalytics(analytics)
@@ -73,16 +75,35 @@ final class OrderDetailsViewModelTests: XCTestCase {
 
     func test_checkShippingLabelCreationEligibility_dispatches_correctly() throws {
         // Given
+
+        // Make sure the are plugins synced
+        let plugin = SystemPlugin.fake().copy(siteID: order.siteID, name: SitePlugin.SupportedPlugin.WCShip, active: true)
+        storageManager.insertSampleSystemPlugin(readOnlySystemPlugin: plugin)
+
         storesManager.reset()
         XCTAssertEqual(storesManager.receivedActions.count, 0)
 
         // When
-        viewModel.checkShippingLabelCreationEligibility()
+        waitForExpectation { exp in
+
+            // Return the active WCShip plugin.
+            storesManager.whenReceivingAction(ofType: SystemStatusAction.self) { action in
+                switch action {
+                case .fetchSystemPlugin(_, _, let onCompletion):
+                    onCompletion(plugin)
+                    exp.fulfill()
+                default:
+                    break
+                }
+            }
+
+            viewModel.checkShippingLabelCreationEligibility()
+        }
 
         // Then
-        XCTAssertEqual(storesManager.receivedActions.count, 1)
+        XCTAssertEqual(storesManager.receivedActions.count, 2)
 
-        let action = try XCTUnwrap(storesManager.receivedActions.first as? ShippingLabelAction)
+        let action = try XCTUnwrap(storesManager.receivedActions.last as? ShippingLabelAction)
         guard case let ShippingLabelAction.checkCreationEligibility(siteID: siteID,
                                                                     orderID: orderID,
                                                                     onCompletion: _) = action else {