[Woo POS] Walkthrough code cleanup (#13799)

Author: staskus

WooCommerce/Classes/POS/ViewModels/ItemListViewModel.swift

@@ -34,7 +34,6 @@ final class ItemListViewModel: ItemListViewModelProtocol {
 
     var itemsPublisher: Published<[POSItem]>.Publisher { $items }
     var statePublisher: Published<ItemListViewModel.ItemListState>.Publisher { $state }
-    var isHeaderBannerDismissedPublisher: Published<Bool>.Publisher { $isHeaderBannerDismissed }
 
     init(itemProvider: POSItemProvider) {
         self.itemProvider = itemProvider
@@ -82,10 +81,6 @@ final class ItemListViewModel: ItemListViewModelProtocol {
 extension ItemListViewModel {
     enum ItemListState: Equatable {
         case empty
-        // TODO:
-        // Differentiate between loading on entering POS mode and reloading, as the
-        // screens will be different:
-        // https://github.com/woocommerce/woocommerce-ios/issues/13286
         case loading
         case loaded([POSItem])
         case error(ErrorModel)

WooCommerce/Classes/POS/ViewModels/ItemListViewModelProtocol.swift

@@ -12,7 +12,6 @@ protocol ItemListViewModelProtocol: ObservableObject {
     var selectedItemPublisher: AnyPublisher<POSItem, Never> { get }
     var itemsPublisher: Published<[POSItem]>.Publisher { get }
     var statePublisher: Published<ItemListViewModel.ItemListState>.Publisher { get }
-    var isHeaderBannerDismissedPublisher: Published<Bool>.Publisher { get }
 
     func select(_ item: POSItem)
     func populatePointOfSaleItems() async

WooCommerce/WooCommerceTests/POS/Mocks/MockItemListViewModel.swift

@@ -11,7 +11,6 @@ class MockItemListViewModel: ItemListViewModelProtocol {
     var statePublisher: Published<WooCommerce.ItemListViewModel.ItemListState>.Publisher { $state }
 
     @Published var isHeaderBannerDismissed: Bool = false
-    var isHeaderBannerDismissedPublisher: Published<Bool>.Publisher { $isHeaderBannerDismissed }
 
     var isEmptyOrError: Bool = false
     var shouldShowHeaderBanner: Bool = false

WooCommerce/WooCommerceTests/POS/ViewModels/ItemListViewModelTests.swift

@@ -266,6 +266,105 @@ final class ItemListViewModelTests: XCTestCase {
         // Then
         XCTAssertEqual(sut.state.isLoaded, false)
     }
+
+    func test_populatePointOfSaleItems_when_no_items_are_loaded_then_itemsPublisher_emits_no_items() async throws {
+        let itemProvider = MockPOSItemProvider()
+        itemProvider.shouldReturnZeroItems = true
+        let sut = ItemListViewModel(itemProvider: itemProvider)
+
+        let expectation = XCTestExpectation(description: "Publisher should emit nothing")
+        var receivedItems: [POSItem] = []
+        sut.itemsPublisher.sink { items in
+            receivedItems = items
+            expectation.fulfill()
+        }
+        .store(in: &cancellables)
+
+        // When
+        await sut.populatePointOfSaleItems()
+
+        // Then
+        XCTAssertTrue(sut.state == .empty)
+        XCTAssertTrue(receivedItems.isEmpty)
+    }
+
+    func test_populatePointOfSaleItems_when_items_are_loaded_then_itemsPublisher_emits_items() async throws {
+        // Given
+        let items = Self.makeItems()
+        let expectation = XCTestExpectation(description: "Publisher should emit populated items")
+        var receivedItems: [POSItem] = []
+        sut.itemsPublisher.sink { items in
+            receivedItems = items
+            expectation.fulfill()
+        }
+        .store(in: &cancellables)
+
+        // When
+        await sut.populatePointOfSaleItems()
+        guard let firstItem = items.first, let lastItem = items.last else {
+            return XCTFail("Expected two items, got \(receivedItems).")
+        }
+
+        // Then
+        XCTAssertTrue(sut.state == .loaded(receivedItems))
+        XCTAssertEqual(receivedItems.first?.productID, firstItem.productID)
+        XCTAssertEqual(receivedItems.last?.productID, lastItem.productID)
+    }
+
+    func test_populatePointOfSaleItems_when_no_items_are_loaded_then_statePublisher_emits_expected_empty_state() async throws {
+        // Given
+        XCTAssertEqual(sut.state, .loading, "Initial state")
+
+        let itemProvider = MockPOSItemProvider()
+        itemProvider.shouldReturnZeroItems = true
+        let sut = ItemListViewModel(itemProvider: itemProvider)
+        let expectation = XCTestExpectation(description: "Publisher should emit state changes")
+
+        var receivedStates: [ItemListViewModel.ItemListState] = []
+        sut.statePublisher
+            .removeDuplicates()
+            .sink { state in
+                receivedStates.append(state)
+                expectation.fulfill()
+        }
+        .store(in: &cancellables)
+
+        // When
+        await sut.populatePointOfSaleItems()
+
+        // Then
+        XCTAssertEqual(receivedStates, [.loading, .empty])
+    }
+
+    func test_populatePointOfSaleItems_when_items_are_loaded_then_statePublisher_emits_expected_loaded_state() async throws {
+        // Given
+        XCTAssertEqual(sut.state, .loading, "Initial state")
+        let expectation = XCTestExpectation(description: "Publisher should emit state changes")
+        let items = Self.makeItems()
+
+        var receivedStates: [ItemListViewModel.ItemListState] = []
+        sut.statePublisher
+            .removeDuplicates()
+            .sink { state in
+                receivedStates.append(state)
+                expectation.fulfill()
+        }
+        .store(in: &cancellables)
+
+        // When
+        await sut.populatePointOfSaleItems()
+
+        // Then
+        XCTAssertEqual(receivedStates, [.loading, .loaded(items)])
+    }
+
+    func test_simpleProductsInfoButtonTapped_when_tapped_then_showSimpleProductsModal_toggled() {
+        XCTAssertFalse(sut.showSimpleProductsModal)
+
+        sut.simpleProductsInfoButtonTapped()
+
+        XCTAssertTrue(sut.showSimpleProductsModal)
+    }
 }
 
 private extension ItemListViewModelTests {

Yosemite/Yosemite/PointOfSale/POSItemProvider.swift

@@ -12,7 +12,14 @@ public protocol POSItem {
 extension POSItem {
     // Equatable conformance
     static func == (lhs: Self, rhs: Self) -> Bool {
-        lhs.itemID == rhs.itemID
+        lhs.itemID == rhs.itemID &&
+        lhs.productID == rhs.productID &&
+        lhs.name == rhs.name &&
+        lhs.price == rhs.price &&
+        lhs.formattedPrice == rhs.formattedPrice &&
+        lhs.itemCategories == rhs.itemCategories &&
+        lhs.productImageSource == rhs.productImageSource &&
+        lhs.productType == rhs.productType
     }
 }
 

Yosemite/Yosemite/PointOfSale/POSProductProvider.swift

@@ -69,9 +69,6 @@ public final class POSProductProvider: POSItemProvider {
                               productType: product.productType)
         }
     }
-
-    // TODO: Mechanism to reload/sync product data.
-    // https://github.com/woocommerce/woocommerce-ios/issues/12837
 }
 
 private extension POSProductProvider {