Skip to content

Commit 92b1a08

Browse files
committed
Configure page control as a constant
1 parent af7fb6e commit 92b1a08

File tree

1 file changed

+10
-13
lines changed

1 file changed

+10
-13
lines changed

WooCommerce/Classes/Authentication/Prologue/LoginProloguePageViewController.swift

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ final class LoginProloguePageViewController: UIPageViewController {
88
LoginProloguePageType.allCases.map { LoginProloguePageTypeViewController(pageType: $0) }
99
}()
1010

11-
private lazy var pageControl = UIPageControl()
11+
private let pageControl = UIPageControl()
1212

1313
init() {
1414
super.init(transitionStyle: .scroll, navigationOrientation: .horizontal)
@@ -33,23 +33,20 @@ final class LoginProloguePageViewController: UIPageViewController {
3333
// MARK: Page Control Setup
3434
//
3535
private func addPageControl() {
36-
let newPageControl = UIPageControl()
37-
newPageControl.currentPageIndicatorTintColor = .gray(.shade5)
38-
newPageControl.pageIndicatorTintColor = .wooCommercePurple(.shade50)
39-
newPageControl.transform = CGAffineTransform(scaleX: Constants.pageControlScale, y: Constants.pageControlScale)
36+
pageControl.currentPageIndicatorTintColor = .gray(.shade5)
37+
pageControl.pageIndicatorTintColor = .wooCommercePurple(.shade50)
38+
pageControl.transform = CGAffineTransform(scaleX: Constants.pageControlScale, y: Constants.pageControlScale)
4039

41-
newPageControl.translatesAutoresizingMaskIntoConstraints = false
42-
view.addSubview(newPageControl)
40+
pageControl.translatesAutoresizingMaskIntoConstraints = false
41+
view.addSubview(pageControl)
4342

4443
NSLayoutConstraint.activate([
45-
newPageControl.centerXAnchor.constraint(equalTo: view.centerXAnchor),
46-
newPageControl.bottomAnchor.constraint(equalTo: view.bottomAnchor, constant: Constants.pageControlBottomMargin)
44+
pageControl.centerXAnchor.constraint(equalTo: view.centerXAnchor),
45+
pageControl.bottomAnchor.constraint(equalTo: view.bottomAnchor, constant: Constants.pageControlBottomMargin)
4746
])
4847

49-
newPageControl.numberOfPages = pages.count
50-
newPageControl.addTarget(self, action: #selector(handlePageControlValueChanged(sender:)), for: .valueChanged)
51-
52-
pageControl = newPageControl
48+
pageControl.numberOfPages = pages.count
49+
pageControl.addTarget(self, action: #selector(handlePageControlValueChanged(sender:)), for: .valueChanged)
5350
}
5451

5552
@objc func handlePageControlValueChanged(sender: UIPageControl) {

0 commit comments

Comments
 (0)