Make CellViewModel.name optional for easier UI handling

Author: shiki

WooCommerce/Classes/ViewRelated/Search/Order/OrderSearchStarterViewController.swift

@@ -68,7 +68,7 @@ extension OrderSearchStarterViewController: UITableViewDataSource {
         let cellViewModel = viewModel.cellViewModel(at: indexPath)
 
         cell.accessoryType = .disclosureIndicator
-        cell.updateUI(title: cellViewModel.name, value: cellViewModel.total)
+        cell.updateUI(title: cellViewModel.name ?? "", value: cellViewModel.total)
 
         return cell
     }

WooCommerce/Classes/ViewRelated/Search/Order/OrderSearchStarterViewModel.swift

@@ -17,7 +17,7 @@ final class OrderSearchStarterViewModel {
     /// The `ViewModel` containing only the data used by the displayed cell.
     ///
     struct CellViewModel {
-        let name: String
+        let name: String?
         let slug: String
         /// The total displayed on the right side.
         ///
@@ -85,7 +85,7 @@ extension OrderSearchStarterViewModel {
 
         let total = NumberFormatter.localizedUpToNinetyNine(orderStatus.total)
 
-        return CellViewModel(name: orderStatus.name ?? "",
+        return CellViewModel(name: orderStatus.name,
                              slug: orderStatus.slug,
                              total: total)
     }