Merge pull request #737 from woocommerce/issue/703-arrow-rtl

mindgraffiti · web-flow · commit 96428235e43d · 2019-03-05T14:04:11.000-06:00
Set the chevron image to flip upon changing to a RTL language
diff --git a/RELEASE-NOTES.txt b/RELEASE-NOTES.txt
@@ -1,5 +1,6 @@
 1.4
 -----
+- bugfix: correctly flips chevron on Dashboard > New Orders, to support RTL languages.
 
 1.3
 -----
diff --git a/WooCommerce/Classes/ViewRelated/Dashboard/MyStore/NewOrdersViewController.swift b/WooCommerce/Classes/ViewRelated/Dashboard/MyStore/NewOrdersViewController.swift
@@ -77,7 +77,7 @@ private extension NewOrdersViewController {
         descriptionLabel.textInsets = Constants.newOrdersDescriptionLabelInsets
         descriptionLabel.text = NSLocalizedString("Review, prepare, and ship these pending orders",
                                                   comment: "Description text used on the UI element displayed when a user has pending orders to process.")
-        chevronImageView.image = UIImage.chevronImage
+        chevronImageView.image = UIImage.chevronImage.imageFlippedForRightToLeftLayoutDirection()
     }
 }
 

-Original file line number
+Diff line change
@@ @@ -1,5 +1,6 @@ @@
 .4
 -----
 +- bugfix: correctly flips chevron on Dashboard > New Orders, to support RTL languages.
 .3
 -----
Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,7 @@ private extension NewOrdersViewController {`
`77`	`77`	`descriptionLabel.textInsets = Constants.newOrdersDescriptionLabelInsets`
`78`	`78`	`descriptionLabel.text = NSLocalizedString("Review, prepare, and ship these pending orders",`
`79`	`79`	`comment: "Description text used on the UI element displayed when a user has pending orders to process.")`
`80`		`- chevronImageView.image = UIImage.chevronImage`
	`80`	`+ chevronImageView.image = UIImage.chevronImage.imageFlippedForRightToLeftLayoutDirection()`
`81`	`81`	`}`
`82`	`82`	`}`
`83`	`83`