Skip to content

Commit 99378ae

Browse files
committed
Remove Products M2 feature flag check from ProductFormBottomSheetListSelectorCommand because the bottom sheet is behind a M2 feature flag.
1 parent 44e5f13 commit 99378ae

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

WooCommerce/Classes/ViewRelated/Products/Edit Product/BottomSheetListSelector/ProductFormBottomSheetListSelectorCommand.swift

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,18 +13,18 @@ final class ProductFormBottomSheetListSelectorCommand: BottomSheetListSelectorCo
1313
private let onSelection: (ProductFormBottomSheetAction) -> Void
1414

1515
init(product: Product,
16-
isEditProductsRelease2Enabled: Bool,
17-
isEditProductsRelease3Enabled: Bool, onSelection: @escaping (ProductFormBottomSheetAction) -> Void) {
16+
isEditProductsRelease3Enabled: Bool,
17+
onSelection: @escaping (ProductFormBottomSheetAction) -> Void) {
1818
self.onSelection = onSelection
1919

2020
let shouldShowShippingSettingsRow = product.isShippingEnabled
21-
let shouldShowBriefDescriptionRow = isEditProductsRelease2Enabled
2221
let shouldShowCategoriesRow = isEditProductsRelease3Enabled
2322
let actions: [ProductFormBottomSheetAction?] = [
2423
.editInventorySettings,
2524
shouldShowShippingSettingsRow ? .editShippingSettings: nil,
2625
shouldShowCategoriesRow ? .editCategories: nil,
27-
shouldShowBriefDescriptionRow ? .editBriefDescription: nil]
26+
.editBriefDescription
27+
]
2828
self.data = actions.compactMap({ $0 })
2929
}
3030

WooCommerce/Classes/ViewRelated/Products/Edit Product/ProductFormViewController.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -188,10 +188,8 @@ private extension ProductFormViewController {
188188
func moreDetailsButtonTapped(button: UIButton) {
189189
let title = NSLocalizedString("Add more details", comment: "")
190190
let viewProperties = BottomSheetListSelectorViewProperties(title: title)
191-
let isEditProductsRelease2Enabled = featureFlagService.isFeatureFlagEnabled(.editProductsRelease2)
192191
let isEditProductsRelease3Enabled = featureFlagService.isFeatureFlagEnabled(.editProductsRelease3)
193192
let dataSource = ProductFormBottomSheetListSelectorCommand(product: product,
194-
isEditProductsRelease2Enabled: isEditProductsRelease2Enabled,
195193
isEditProductsRelease3Enabled: isEditProductsRelease3Enabled) { [weak self] action in
196194
self?.dismiss(animated: true) { [weak self] in
197195
switch action {

0 commit comments

Comments
 (0)