Observe dashboard UI and site observable to update Jetpack benefits banner visibility.

Author: jaclync

WooCommerce/Classes/ViewRelated/Dashboard/DashboardViewController.swift

@@ -15,7 +15,7 @@ final class DashboardViewController: UIViewController {
     private let siteID: Int64
 
     private let dashboardUIFactory: DashboardUIFactory
-    private var dashboardUI: DashboardUI?
+    @Published private var dashboardUI: DashboardUI?
 
     // Used to enable subtitle with store name
     private var shouldShowStoreNameAsSubtitle: Bool = false
@@ -110,6 +110,7 @@ final class DashboardViewController: UIViewController {
         configureDashboardUIContainer()
         configureBottomJetpackBenefitsBanner()
         observeSiteForUIUpdates()
+        observeBottomJetpackBenefitsBannerVisibilityUpdates()
     }
 
     override func viewWillAppear(_ animated: Bool) {
@@ -323,25 +324,25 @@ private extension DashboardViewController {
             remove(previousDashboardUI)
         }
 
-        dashboardUI = updatedDashboardUI
-
         let contentView = updatedDashboardUI.view!
         addChild(updatedDashboardUI)
         containerView.addSubview(contentView)
         updatedDashboardUI.didMove(toParent: self)
         addViewBelowHeaderStackView(contentView: contentView)
 
+        // Sets `dashboardUI` after its view is added to the view hierarchy so that observers can update UI based on its view.
+        dashboardUI = updatedDashboardUI
+
         updatedDashboardUI.onPullToRefresh = { [weak self] in
             self?.pullToRefresh()
         }
         updatedDashboardUI.displaySyncingError = { [weak self] in
             self?.showTopBannerView()
         }
+    }
 
-        // Bottom banner
-        // TODO: 5362 & 5368 - Display banner for JCP sites and if the banner has not been dismissed before.
-        let shouldShowJetpackBenefitsBanner = ServiceLocator.featureFlagService.isFeatureFlagEnabled(.jetpackConnectionPackageSupport)
-        if shouldShowJetpackBenefitsBanner {
+    func updateJetpackBenefitsBannerVisibility(isBannerVisible: Bool, contentView: UIView) {
+        if isBannerVisible {
             showJetpackBenefitsBanner(contentView: contentView)
         } else {
             hideJetpackBenefitsBanner()
@@ -426,6 +427,23 @@ private extension DashboardViewController {
             self.reloadData(forced: true)
         }.store(in: &cancellables)
     }
+
+    func observeBottomJetpackBenefitsBannerVisibilityUpdates() {
+        Publishers.CombineLatest(ServiceLocator.stores.site, $dashboardUI.eraseToAnyPublisher())
+            .sink { [weak self] site, dashboardUI in
+                guard let self = self else { return }
+
+                guard let contentView = dashboardUI?.view else {
+                    return
+                }
+
+                // TODO: 5362 - Display banner for JCP sites only if the banner has not been dismissed before.
+                let shouldShowJetpackBenefitsBanner = ServiceLocator.featureFlagService.isFeatureFlagEnabled(.jetpackConnectionPackageSupport)
+                && site?.isJetpackCPConnected == true
+
+                self.updateJetpackBenefitsBannerVisibility(isBannerVisible: shouldShowJetpackBenefitsBanner, contentView: contentView)
+            }.store(in: &cancellables)
+    }
 }
 
 // MARK: Constants