Skip to content

Commit 9ce0ff5

Browse files
Copilotmokagio
andcommitted
Rename PULL_REQUEST_NUMBER to pull_request_number
Co-authored-by: mokagio <[email protected]>
1 parent 153f41f commit 9ce0ff5

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

fastlane/Fastfile

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -780,7 +780,7 @@ platform :ios do
780780
Branch: `#{ENV.fetch('BUILDKITE_BRANCH', 'N/A')}`
781781
Commit: #{ENV.fetch('BUILDKITE_COMMIT', 'N/A')[0...7]}
782782
NOTES
783-
release_notes += "Pull Request: ##{PULL_REQUEST_NUMBER}" unless PULL_REQUEST_NUMBER.nil?
783+
release_notes += "Pull Request: ##{pull_request_number}" unless pull_request_number.nil?
784784

785785
firebase_app_distribution(
786786
app: FIREBASE_APP_ID,
@@ -796,13 +796,13 @@ platform :ios do
796796
dsym_path: './build/WooCommerce.app.dSYM.zip'
797797
)
798798

799-
next if PULL_REQUEST_NUMBER.nil?
799+
next if pull_request_number.nil?
800800

801801
# PR Comment
802802
comment_body = prototype_build_details_comment(app_display_name: 'WooCommerce iOS Prototype')
803803
comment_on_pr(
804804
project: GITHUB_REPO,
805-
pr_number: PULL_REQUEST_NUMBER,
805+
pr_number: pull_request_number,
806806
reuse_identifier: 'prototype-build-link',
807807
body: comment_body
808808
)
@@ -812,7 +812,7 @@ platform :ios do
812812
lane :build_for_prototype_build do |fetch_code_signing: true|
813813
update_certs_and_profiles_enterprise if fetch_code_signing
814814

815-
pr_prefix = PULL_REQUEST_NUMBER&.then { |num| "pr#{num}" }
815+
pr_prefix = pull_request_number&.then { |num| "pr#{num}" }
816816
commit_short_hash = ENV.fetch('BUILDKITE_COMMIT', '0')[0...7]
817817
build_number = [pr_prefix, commit_short_hash].compact.join('-')
818818

@@ -1527,7 +1527,7 @@ TEST_ANALYTICS_ENVIRONMENT = %w[
15271527
# -----------------------------------------------------------------------------------
15281528

15291529
# Buildkite sets this env var to the PR number if on a PR, but to 'false' (and not nil) if not on a PR
1530-
PULL_REQUEST_NUMBER = ENV['BUILDKITE_PULL_REQUEST']&.then { |n| n == 'false' ? nil : Integer(n) }
1530+
pull_request_number = ENV['BUILDKITE_PULL_REQUEST']&.then { |n| n == 'false' ? nil : Integer(n) }
15311531

15321532
def create_backmerge_pr
15331533
version = release_version_current

0 commit comments

Comments
 (0)