Refactor error handling in ApplicationPasswordAuthorizationWebViewController and display errorUI instead of error alert

Author: pmusolino

WooCommerce/Classes/Authentication/Application Password/ApplicationPasswordAuthorizationWebViewController.swift

@@ -162,28 +162,14 @@ private extension ApplicationPasswordAuthorizationWebViewController {
                 guard let url = try await viewModel.fetchAuthURL() else {
                     DDLogError("⛔️ No authorization URL found for application passwords")
                     analytics.track(.applicationPasswordAuthorizationURLNotAvailable)
-
-                    let errorUI = applicationPasswordDisabledUI(for: viewModel.siteURL)
-                    // When the error view controller is popped, navigate to previous VC
-                    errorUI.navigationItem.leftBarButtonItem = UIBarButtonItem(
-                        image: UIImage(systemName: "chevron.backward"),
-                        style: .plain,
-                        target: self,
-                        action: #selector(navigateToPreviousViewController)
-                    )
-
-                    // Push instead of present
-                    navigationController?.pushViewController(errorUI, animated: true)
-
+                    navigateToErrorUI()
                     return
                 }
                 loadAuthorizationPage(url: url)
             } catch {
                 DDLogError("⛔️ Error fetching authorization URL for application passwords \(error)")
                 analytics.track(.applicationPasswordAuthorizationURLFetchFailed, withError: error)
-                showErrorAlert(message: Localization.errorFetchingAuthURL, onRetry: { [weak self] in
-                    self?.fetchAuthorizationURL()
-                })
+                navigateToErrorUI()
             }
             activityIndicator.stopAnimating()
         }
@@ -198,6 +184,19 @@ private extension ApplicationPasswordAuthorizationWebViewController {
         }
     }
 
+    private func navigateToErrorUI() {
+        let errorUI = applicationPasswordDisabledUI(for: viewModel.siteURL)
+        // When the error view controller is popped, navigate to previous VC
+        errorUI.navigationItem.leftBarButtonItem = UIBarButtonItem(
+            image: UIImage(systemName: "chevron.backward"),
+            style: .plain,
+            target: self,
+            action: #selector(navigateToPreviousViewController)
+        )
+        // Push instead of present
+        navigationController?.pushViewController(errorUI, animated: true)
+    }
+
     func loadAuthorizationPage(url: URL) {
         let parameters: [URLQueryItem] = [
             URLQueryItem(name: Constants.Query.appName, value: appName),
@@ -317,9 +316,5 @@ private extension ApplicationPasswordAuthorizationWebViewController {
             comment: "Error message displayed when application password authorization fails " +
             "during login due to the feature being disabled on the input site."
         )
-        static let errorFetchingAuthURL = NSLocalizedString(
-            "Failed to fetch the authorization URL for application passwords. Please try again.",
-            comment: "Error message displayed when failed to fetch application password authorization URL during login"
-        )
     }
 }