Move logic for filter button title to the view model

Author: itsmeichigo

WooCommerce/Classes/Bookings/BookingList/BookingListContainerView.swift

@@ -84,15 +84,9 @@ private extension BookingListContainerView {
                 Button {
                     showingFilters = true
                 } label: {
-                    if viewModel.numberOfActiveFilters > 0 {
-                        Text(Localization.filterWithCount(viewModel.numberOfActiveFilters))
-                            .font(.body)
-                            .foregroundStyle(Color.accentColor)
-                    } else {
-                        Text(Localization.filter)
-                            .font(.body)
-                            .foregroundStyle(Color.accentColor)
-                    }
+                    Text(viewModel.filterText)
+                        .font(.body)
+                        .foregroundStyle(Color.accentColor)
                 }
                 .renderedIf(viewModel.selectedTab == .all)
             }
@@ -209,21 +203,6 @@ private extension BookingListContainerView {
             value: "Sort by",
             comment: "Button to select the order of the booking list"
         )
-        static let filter = NSLocalizedString(
-            "bookingListView.filter",
-            value: "Filter",
-            comment: "Button to filter the booking list"
-        )
-        static func filterWithCount(_ count: Int) -> String {
-            String.localizedStringWithFormat(
-                NSLocalizedString(
-                    "bookingListView.filter.withCount",
-                    value: "Filter (%d)",
-                    comment: "Button to filter the booking list with number of active filters"
-                ),
-                count
-            )
-        }
         static let searchPrompt = NSLocalizedString(
             "bookingListView.search.prompt",
             value: "Search bookings",

WooCommerce/Classes/Bookings/BookingList/BookingListContainerViewModel.swift

@@ -24,6 +24,10 @@ final class BookingListContainerViewModel: ObservableObject {
 
     private var filters = BookingFiltersViewModel.Filters()
 
+    var filterText: String {
+        numberOfActiveFilters == 0 ? Localization.filter : String.localizedStringWithFormat(Localization.filterWithCount, numberOfActiveFilters)
+    }
+
     var filterViewModel: BookingFiltersViewModel {
         BookingFiltersViewModel(filter: filters, siteID: siteID)
     }
@@ -108,6 +112,21 @@ final class BookingListContainerViewModel: ObservableObject {
     }
 }
 
+private extension BookingListContainerViewModel {
+    enum Localization {
+        static let filter = NSLocalizedString(
+            "bookingListView.filter",
+            value: "Filter",
+            comment: "Button to filter the booking list"
+        )
+        static let filterWithCount = NSLocalizedString(
+            "bookingListView.filter.withCount",
+            value: "Filter (%1$d)",
+            comment: "Button to filter the booking list with number of active filters"
+        )
+    }
+}
+
 enum BookingListTab: Int, CaseIterable {
     case today
     case upcoming