Skip to content

Commit a23fb7d

Browse files
committed
Use [weak self] within sink that creates a Task {}
Not using [weak self] here strongly captures self within a Task and doesn't release aggregate model after closing POS
1 parent 39f0030 commit a23fb7d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

WooCommerce/Classes/POS/Models/PointOfSaleAggregateModel.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ extension PointOfSaleAggregateModel {
184184
}
185185
}
186186
.removeDuplicates()
187-
.sink { _ in
187+
.sink { [weak self] _ in
188188
Task { @MainActor [weak self] in
189189
await self?.collectCardPayment()
190190
}

0 commit comments

Comments
 (0)