Skip to content

Commit a377b64

Browse files
committed
Add @MainActor to Task in view controllers to be extra sure.
1 parent 0b30f5c commit a377b64

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

WooCommerce/Classes/ViewRelated/Dashboard/DashboardViewController.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ final class DashboardViewController: UIViewController {
116116
observeBottomJetpackBenefitsBannerVisibilityUpdates()
117117
observeNavigationBarHeightForStoreNameLabelVisibility()
118118
observeStatsVersionForDashboardUIUpdates()
119-
Task {
119+
Task { @MainActor in
120120
await reloadDashboardUIStatsVersion(forced: true)
121121
}
122122
}
@@ -318,7 +318,7 @@ extension DashboardViewController: DashboardUIScrollDelegate {
318318
private extension DashboardViewController {
319319
func onDashboardUIUpdate(forced: Bool, updatedDashboardUI: DashboardUI) {
320320
defer {
321-
Task { [weak self] in
321+
Task { @MainActor [weak self] in
322322
// Reloads data of the updated dashboard UI at the end.
323323
await self?.reloadData(forced: true)
324324
}
@@ -444,7 +444,7 @@ private extension DashboardViewController {
444444
return
445445
}
446446
self.updateUI(site: site)
447-
Task { [weak self] in
447+
Task { @MainActor [weak self] in
448448
await self?.reloadData(forced: true)
449449
}
450450
}.store(in: &subscriptions)

WooCommerce/Classes/ViewRelated/Dashboard/Stats v3/DeprecatedStatsDashboardViewController.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ private extension DeprecatedDashboardStatsViewController {
6868
scrollView.refreshControl = refreshControl
6969
refreshControl.on(.valueChanged) { [weak self] refreshControl in
7070
guard let self = self else { return }
71-
Task {
71+
Task { @MainActor in
7272
await self.onPullToRefresh()
7373
self.refreshControl.endRefreshing()
7474
}

WooCommerce/Classes/ViewRelated/Dashboard/Stats v4/StoreStatsAndTopPerformersPeriodViewController.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,7 @@ private extension StoreStatsAndTopPerformersPeriodViewController {
337337
//
338338
private extension StoreStatsAndTopPerformersPeriodViewController {
339339
@objc func pullToRefresh() {
340-
Task {
340+
Task { @MainActor in
341341
await onPullToRefresh()
342342
}
343343
}

0 commit comments

Comments
 (0)