Merge pull request #6053 from woocommerce/issue/5946-order-items-subtotal

Order Creation: Update price label when product quantity changes

Author: rachelmcr

WooCommerce/Classes/ViewRelated/Orders/Order Creation/ProductsSection/ProductRowViewModel.swift

@@ -51,15 +51,15 @@ final class ProductRowViewModel: ObservableObject, Identifiable {
 
     /// Label showing product details: stock status, price, and variations (if any).
     ///
-    lazy var productDetailsLabel: String = {
+    var productDetailsLabel: String {
         let stockLabel = createStockText()
         let priceLabel = createPriceText()
         let variationsLabel = createVariationsText()
 
         return [stockLabel, priceLabel, variationsLabel]
             .compactMap({ $0 })
             .joined(separator: " • ")
-    }()
+    }
 
     /// Label showing product SKU
     ///
@@ -191,14 +191,14 @@ final class ProductRowViewModel: ObservableObject, Identifiable {
         }
     }
 
-    /// Create the price text based on a product's price.
+    /// Create the price text based on a product's price and quantity.
     ///
     private func createPriceText() -> String? {
         guard let price = price else {
             return nil
         }
-        let unformattedPrice = price.isNotEmpty ? price : "0"
-        return currencyFormatter.formatAmount(unformattedPrice)
+        let productSubtotal = quantity * (currencyFormatter.convertToDecimal(from: price)?.decimalValue ?? Decimal.zero)
+        return currencyFormatter.formatAmount(productSubtotal)
     }
 
     /// Create the variations text for a variable product.

WooCommerce/WooCommerceTests/ViewRelated/Orders/Order Creation/ProductRowViewModelTests.swift

@@ -129,6 +129,21 @@ class ProductRowViewModelTests: XCTestCase {
                       "Expected label to contain \"\(expectedPriceLabel)\" but actual label was \"\(viewModel.productDetailsLabel)\"")
     }
 
+    func test_view_model_updates_price_label_when_quantity_changes() {
+        // Given
+        let product = Product.fake().copy(price: "2.50")
+        let currencyFormatter = CurrencyFormatter(currencySettings: CurrencySettings()) // Defaults to US currency & format
+
+        // When
+        let viewModel = ProductRowViewModel(product: product, canChangeQuantity: false, currencyFormatter: currencyFormatter)
+        viewModel.incrementQuantity()
+
+        // Then
+        let expectedPriceLabel = "$5.00"
+        XCTAssertTrue(viewModel.productDetailsLabel.contains(expectedPriceLabel),
+                      "Expected label to contain \"\(expectedPriceLabel)\" but actual label was \"\(viewModel.productDetailsLabel)\"")
+    }
+
     func test_view_model_creates_expected_product_details_label_for_variable_product() {
         // Given
         let product = Product.fake().copy(productTypeKey: "variable", stockStatusKey: "instock", variations: [0, 1])