Update unit tests for AuthenticationManager

Author: itsmeichigo

WooCommerce/WooCommerceTests/Authentication/AuthenticationManagerTests.swift

@@ -159,7 +159,40 @@ final class AuthenticationManagerTests: XCTestCase {
         // Given
         let manager = AuthenticationManager()
         let testSite = "http://test.com"
-        let siteInfo = WordPressComSiteInfo(remote: ["isWordPress": true, "hasJetpack": false, "urlAfterRedirects": testSite])
+        let siteInfo = siteInfo(url: testSite,
+                                exists: true,
+                                hasWordPress: true,
+                                isWordPressCom: false,
+                                hasJetpack: false,
+                                isJetpackActive: false,
+                                isJetpackConnected: false)
+        let wpcomCredentials = WordPressComCredentials(authToken: "abc", isJetpackLogin: false, multifactor: false, siteURL: testSite)
+        let credentials = AuthenticatorCredentials(wpcom: wpcomCredentials, wporg: nil)
+        let navigationController = UINavigationController()
+
+        // When
+        manager.shouldPresentUsernamePasswordController(for: siteInfo, onCompletion: { _ in })
+        manager.presentLoginEpilogue(in: navigationController, for: credentials, onDismiss: {})
+        waitUntil {
+            navigationController.viewControllers.isNotEmpty
+        }
+
+        // Then
+        let rootController = navigationController.viewControllers.first
+        XCTAssertTrue(rootController is ULErrorViewController)
+    }
+
+    func test_it_shows_error_upon_login_epilogue_if_the_site_has_active_jetpack_but_not_connected() {
+        // Given
+        let manager = AuthenticationManager()
+        let testSite = "http://test.com"
+        let siteInfo = siteInfo(url: testSite,
+                                exists: true,
+                                hasWordPress: true,
+                                isWordPressCom: false,
+                                hasJetpack: true,
+                                isJetpackActive: true,
+                                isJetpackConnected: false)
         let wpcomCredentials = WordPressComCredentials(authToken: "abc", isJetpackLogin: false, multifactor: false, siteURL: testSite)
         let credentials = AuthenticatorCredentials(wpcom: wpcomCredentials, wporg: nil)
         let navigationController = UINavigationController()
@@ -366,10 +399,28 @@ final class AuthenticationManagerTests: XCTestCase {
         XCTAssertTrue(topController is ULErrorViewController)
     }
 
+    func test_troubleshootSite_displays_error_screen_if_site_is_self_hosted_with_jetpack_not_connected() {
+        // Given
+        let navigationController = UINavigationController()
+        let siteInfo = siteInfo(exists: true, hasWordPress: true, isWordPressCom: false, hasJetpack: true, isJetpackActive: true, isJetpackConnected: false)
+        let storage = MockStorageManager()
+        let manager = AuthenticationManager(storageManager: storage)
+
+        // When
+        manager.troubleshootSite(siteInfo, in: navigationController)
+
+        // Then
+        waitUntil {
+            navigationController.viewControllers.isNotEmpty
+        }
+        let topController = navigationController.topViewController
+        XCTAssertTrue(topController is ULErrorViewController)
+    }
+
     func test_troubleshootSite_displays_account_mismatch_screen_if_site_is_self_hosted_with_jetpack() {
         // Given
         let navigationController = UINavigationController()
-        let siteInfo = siteInfo(exists: true, hasWordPress: true, isWordPressCom: false, hasJetpack: true)
+        let siteInfo = siteInfo(exists: true, hasWordPress: true, isWordPressCom: false, hasJetpack: true, isJetpackActive: true, isJetpackConnected: true)
         let storage = MockStorageManager()
         let manager = AuthenticationManager(storageManager: storage)
 
@@ -386,12 +437,19 @@ final class AuthenticationManagerTests: XCTestCase {
 }
 
 private extension AuthenticationManagerTests {
-    func siteInfo(exists: Bool = false, hasWordPress: Bool = false, isWordPressCom: Bool = false, hasJetpack: Bool = false) -> WordPressComSiteInfo {
-        WordPressComSiteInfo(remote: ["exists": exists,
+    func siteInfo(url: String = "",
+                  exists: Bool = false,
+                  hasWordPress: Bool = false,
+                  isWordPressCom: Bool = false,
+                  hasJetpack: Bool = false,
+                  isJetpackActive: Bool = false,
+                  isJetpackConnected: Bool = false) -> WordPressComSiteInfo {
+        WordPressComSiteInfo(remote: ["urlAfterRedirects": url,
+                                      "exists": exists,
                                       "isWordPress": hasWordPress,
                                       "hasJetpack": hasJetpack,
-                                      "isJetpackActive": hasJetpack,
-                                      "isJetpackConnected": hasJetpack,
+                                      "isJetpackActive": isJetpackActive,
+                                      "isJetpackConnected": isJetpackConnected,
                                       "isWordPressDotCom": isWordPressCom])
     }
 }