DI view model to HubMenu from HubMenuViewController so that we can show review details without calling the view.

Author: jaclync

WooCommerce/Classes/ViewRelated/Hub Menu/HubMenu.swift

@@ -21,8 +21,8 @@ struct HubMenu: View {
     ///
     private let timer = Timer.publish(every: 1, on: .main, in: .common).autoconnect()
 
-    init(siteID: Int64, navigationController: UINavigationController? = nil) {
-        viewModel = HubMenuViewModel(siteID: siteID, navigationController: navigationController)
+    init(viewModel: HubMenuViewModel) {
+        self.viewModel = viewModel
     }
 
     var body: some View {
@@ -111,10 +111,6 @@ struct HubMenu: View {
         }
     }
 
-    func pushReviewDetailsView(using parcel: ProductReviewFromNoteParcel) {
-        viewModel.showReviewDetails(using: parcel)
-    }
-
     /// Reset state to make the menu items tappable
     private func enableMenuItemTaps() {
         shouldDisableItemTaps = false
@@ -213,17 +209,17 @@ struct HubMenu: View {
 
 struct HubMenu_Previews: PreviewProvider {
     static var previews: some View {
-        HubMenu(siteID: 123)
+        HubMenu(viewModel: .init(siteID: 123))
             .environment(\.colorScheme, .light)
 
-        HubMenu(siteID: 123)
+        HubMenu(viewModel: .init(siteID: 123))
             .environment(\.colorScheme, .dark)
 
-        HubMenu(siteID: 123)
+        HubMenu(viewModel: .init(siteID: 123))
             .previewLayout(.fixed(width: 312, height: 528))
             .environment(\.sizeCategory, .accessibilityExtraExtraExtraLarge)
 
-        HubMenu(siteID: 123)
+        HubMenu(viewModel: .init(siteID: 123))
             .previewLayout(.fixed(width: 1024, height: 768))
     }
 }

WooCommerce/Classes/ViewRelated/Hub Menu/HubMenuViewController.swift

@@ -4,9 +4,11 @@ import Yosemite
 
 /// Displays a grid view of all available menu in the "Menu" tab (eg. View Store, Reviews, Coupons, etc...)
 final class HubMenuViewController: UIHostingController<HubMenu> {
+    private let viewModel: HubMenuViewModel
 
     init(siteID: Int64, navigationController: UINavigationController?) {
-        super.init(rootView: HubMenu(siteID: siteID, navigationController: navigationController))
+        self.viewModel = HubMenuViewModel(siteID: siteID, navigationController: navigationController)
+        super.init(rootView: HubMenu(viewModel: viewModel))
         configureTabBarItem()
     }
 
@@ -17,7 +19,7 @@ final class HubMenuViewController: UIHostingController<HubMenu> {
     /// Present the specific Review Details View from a push notification
     ///
     func pushReviewDetailsViewController(using parcel: ProductReviewFromNoteParcel) {
-        rootView.pushReviewDetailsView(using: parcel)
+        viewModel.showReviewDetails(using: parcel)
     }
 }