Merge pull request #7348 from woocommerce/issue/7322-upsell-card-readers-banner-settings-refresh

[Mobile Payments] Refresh Upsell Card Readers Banner when opening Settings.

Author: toupper

WooCommerce/Classes/ViewRelated/Dashboard/Settings/Settings/SettingsViewController.swift

@@ -59,6 +59,12 @@ final class SettingsViewController: UIViewController {
         viewModel.onViewDidLoad()
     }
 
+    override func viewWillAppear(_ animated: Bool) {
+        super.viewWillAppear(animated)
+
+        viewModel.reloadSettings()
+    }
+
     override func viewDidLayoutSubviews() {
         super.viewDidLayoutSubviews()
         tableView.updateFooterHeight()
@@ -178,7 +184,7 @@ private extension SettingsViewController {
     func configureUpsellCardReadersFeatureAnnouncement(cell: HostingTableViewCell<FeatureAnnouncementCardView>) {
         let view = FeatureAnnouncementCardView(viewModel: viewModel.upsellCardReadersAnnouncementViewModel,
                                                dismiss: { [weak self] in
-            self?.viewModel.onUpsellCardReadersAnnouncementDismiss()
+            self?.viewModel.reloadSettings()
         })
         cell.host(view, parent: self)
         cell.selectionStyle = .none

WooCommerce/Classes/ViewRelated/Dashboard/Settings/Settings/SettingsViewModel.swift

@@ -43,7 +43,9 @@ protocol SettingsViewModelActionsHandler {
     ///
     func onJetpackInstallDismiss()
 
-    func onUpsellCardReadersAnnouncementDismiss()
+    /// Reloads settings. This can be used to show or hide content depending on their visibility logic.
+    ///
+    func reloadSettings()
 }
 
 protocol SettingsViewModelInput: AnyObject {
@@ -166,19 +168,15 @@ final class SettingsViewModel: SettingsViewModelOutput, SettingsViewModelActions
         reloadSettings()
     }
 
-    func onUpsellCardReadersAnnouncementDismiss() {
-        reloadSettings()
-    }
-}
-
-private extension SettingsViewModel {
     /// Reload the sections and refresh the view (presenter)
     ///
     func reloadSettings() {
         configureSections()
         presenter?.refreshViewContent()
     }
+}
 
+private extension SettingsViewModel {
     func loadWhatsNewOnWooCommerce() {
         stores.dispatch(AnnouncementsAction.loadSavedAnnouncement(onCompletion: { [weak self] result in
             guard let self = self else { return }