Fix ViewModel premature deallocation in step update tests

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: adborbas

WooCommerce/WooCommerceTests/ViewRelated/JetpackSetup/WPComLogin/WPComConnectionSetup/WPComConnectionSetupViewModelTests.swift

@@ -228,32 +228,35 @@ final class WPComConnectionSetupViewModelTests: XCTestCase {
         do {
             let provider = MockAnalyticsProvider()
             let analytics = WooAnalytics(analyticsProvider: provider)
-            let _ = makeViewModel(analytics: analytics)
-
-            mockHandler.simulateStepUpdate(.connect, status: .success)
+            let viewModel = makeViewModel(analytics: analytics)
+            withExtendedLifetime(viewModel) {
+                mockHandler.simulateStepUpdate(.connect, status: .success)
 
-            assertEqual(provider, eventName: "push_notifications_setup_flow_success", property: "step", expected: "connect_wpcom")
+                assertEqual(provider, eventName: "push_notifications_setup_flow_success", property: "step", expected: "connect_wpcom")
+            }
         }
 
         do {
             let provider = MockAnalyticsProvider()
             let analytics = WooAnalytics(analyticsProvider: provider)
-            let _ = makeViewModel(analytics: analytics)
-
-            mockHandler.simulateStepUpdate(.enablePush, status: .success)
+            let viewModel = makeViewModel(analytics: analytics)
+            withExtendedLifetime(viewModel) {
+                mockHandler.simulateStepUpdate(.enablePush, status: .success)
 
-            assertEqual(provider, eventName: "push_notifications_setup_flow_success", property: "step", expected: "enable_push_notifications")
+                assertEqual(provider, eventName: "push_notifications_setup_flow_success", property: "step", expected: "enable_push_notifications")
+            }
         }
 
         // When step fails, then tracks flow_error with correct step
         do {
             let provider = MockAnalyticsProvider()
             let analytics = WooAnalytics(analyticsProvider: provider)
-            let _ = makeViewModel(analytics: analytics)
-
-            mockHandler.simulateStepUpdate(.checkPlugin, status: .failure(error: .generic(reason: "Network error")))
+            let viewModel = makeViewModel(analytics: analytics)
+            withExtendedLifetime(viewModel) {
+                mockHandler.simulateStepUpdate(.checkPlugin, status: .failure(error: .generic(reason: "Network error")))
 
-            assertEqual(provider, eventName: "push_notifications_setup_flow_error", property: "step", expected: "plugin_compatibility")
+                assertEqual(provider, eventName: "push_notifications_setup_flow_error", property: "step", expected: "plugin_compatibility")
+            }
         }
     }