Show sucess notices after completing payments

Author: Ecarrion

WooCommerce/Classes/ViewRelated/Orders/Simple Payments/Method/SimplePaymentsMethodsViewModel.swift

@@ -105,6 +105,7 @@ final class SimplePaymentsMethodsViewModel: ObservableObject {
 
             if error == nil {
                 onSuccess()
+                self.presentNoticeSubject.send(.completed)
             } else {
                 self.presentNoticeSubject.send(.error(Localization.markAsPaidError))
             }
@@ -137,13 +138,14 @@ final class SimplePaymentsMethodsViewModel: ObservableObject {
                                                             paymentGatewayAccount: paymentGateway,
                                                             rootViewController: rootViewController)
         collectPaymentsUseCase?.collectPayment(onCollect: { _ in
-            print("On collect does nothing for now...")
+            /* No op. */
         }, onCompleted: { [weak self] in
-            // TODO: Show success notice
-
             // Inform success to consumer
             onSuccess()
 
+            // Sent notice request
+            self?.presentNoticeSubject.send(.completed)
+
             // Make sure we free all the resources
             self?.collectPaymentsUseCase = nil
         })

WooCommerce/WooCommerceTests/ViewRelated/Orders/Simple Payments/SimplePaymentsAmountViewModelTests.swift

@@ -300,6 +300,8 @@ final class SimplePaymentsAmountViewModelTests: XCTestCase {
                 switch intent {
                 case .error:
                     promise(true)
+                case .completed:
+                    promise(false)
                 }
             }
             .store(in: &self.subscriptions)

WooCommerce/WooCommerceTests/ViewRelated/Orders/Simple Payments/SimplePaymentsMethodsViewModelTests.swift

@@ -88,6 +88,38 @@ final class SimplePaymentsMethodsViewModelTests: XCTestCase {
         XCTAssertTrue(onSuccessInvoked)
     }
 
+    func test_view_model_attempts_completed_notice_presentation_when_marking_an_order_as_paid() {
+        // Given
+        let stores = MockStoresManager(sessionManager: .testingInstance)
+        let noticeSubject = PassthroughSubject<SimplePaymentsNotice, Never>()
+        let viewModel = SimplePaymentsMethodsViewModel(formattedTotal: "$12.00", presentNoticeSubject: noticeSubject, stores: stores)
+        stores.whenReceivingAction(ofType: OrderAction.self) { action in
+            switch action {
+            case let .updateOrderStatus(_, _, _, onCompletion):
+                onCompletion(nil)
+            default:
+                XCTFail("Unexpected action: \(action)")
+            }
+        }
+
+        // When
+        let receivedCompleted: Bool = waitFor { promise in
+            noticeSubject.sink { intent in
+                switch intent {
+                case .error:
+                    promise(false)
+                case .completed:
+                    promise(true)
+                }
+            }
+            .store(in: &self.subscriptions)
+            viewModel.markOrderAsPaid(onSuccess: {})
+        }
+
+        // Then
+        XCTAssertTrue(receivedCompleted)
+    }
+
     func test_view_model_attempts_error_notice_presentation_when_failing_to_mark_order_as_paid() {
         // Given
         let stores = MockStoresManager(sessionManager: .testingInstance)
@@ -108,6 +140,8 @@ final class SimplePaymentsMethodsViewModelTests: XCTestCase {
                 switch intent {
                 case .error:
                     promise(true)
+                case .completed:
+                    promise(false)
                 }
             }
             .store(in: &self.subscriptions)

WooCommerce/WooCommerceTests/ViewRelated/Orders/Simple Payments/SimplePaymentsSummaryViewModelTests.swift

@@ -133,6 +133,8 @@ final class SimplePaymentsSummaryViewModelTests: XCTestCase {
                 switch intent {
                 case .error:
                     promise(true)
+                case .completed:
+                    promise(false)
                 }
             }
             .store(in: &self.subscriptions)