Prepend https to tracking urls if necessary

Fix whitespacing

Author: ctarda

WooCommerce/Classes/Extensions/String+Woo.swift

@@ -17,3 +17,16 @@ extension String {
         return " "
     }
 }
+
+
+/// String: URL manipulation
+///
+extension String {
+    func addHTTPSSchemeIfNecessary() -> String {
+        if self.hasPrefix("http://") || self.hasPrefix("https://") {
+            return self
+        }
+
+        return "https://\(self)"
+    }
+}

WooCommerce/Classes/ViewRelated/Orders/OrderDetailsViewController.swift

@@ -660,7 +660,8 @@ private extension OrderDetailsViewController {
             return
         }
 
-        guard let trackingURL = tracking.trackingURL, let url = URL(string: trackingURL) else {
+        guard let trackingURL = tracking.trackingURL?.addHTTPSSchemeIfNecessary(),
+            let url = URL(string: trackingURL) else {
             return
         }
 

WooCommerce/WooCommerce.xcodeproj/project.pbxproj

@@ -292,6 +292,7 @@
 		D816DDBC22265DA300903E59 /* OrderTrackingTableViewCellTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = D816DDBB22265DA300903E59 /* OrderTrackingTableViewCellTests.swift */; };
 		D83C129F22250BF0004CA04C /* OrderTrackingTableViewCell.xib in Resources */ = {isa = PBXBuildFile; fileRef = D83C129D22250BEF004CA04C /* OrderTrackingTableViewCell.xib */; };
 		D83C12A022250BF0004CA04C /* OrderTrackingTableViewCell.swift in Sources */ = {isa = PBXBuildFile; fileRef = D83C129E22250BEF004CA04C /* OrderTrackingTableViewCell.swift */; };
+		D85B833D2230DC9D002168F3 /* StringWooTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = D85B833C2230DC9D002168F3 /* StringWooTests.swift */; };
 /* End PBXBuildFile section */
 
 /* Begin PBXContainerItemProxy section */
@@ -630,6 +631,7 @@
 		D816DDBB22265DA300903E59 /* OrderTrackingTableViewCellTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = OrderTrackingTableViewCellTests.swift; sourceTree = "<group>"; };
 		D83C129D22250BEF004CA04C /* OrderTrackingTableViewCell.xib */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = file.xib; path = OrderTrackingTableViewCell.xib; sourceTree = "<group>"; };
 		D83C129E22250BEF004CA04C /* OrderTrackingTableViewCell.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = OrderTrackingTableViewCell.swift; sourceTree = "<group>"; };
+		D85B833C2230DC9D002168F3 /* StringWooTests.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; name = StringWooTests.swift; path = WooCommerceTests/Extensions/StringWooTests.swift; sourceTree = SOURCE_ROOT; };
 /* End PBXFileReference section */
 
 /* Begin PBXFrameworksBuildPhase section */
@@ -982,6 +984,7 @@
 		B57C744F20F56ED300EEFC87 /* Extensions */ = {
 			isa = PBXGroup;
 			children = (
+				D85B833C2230DC9D002168F3 /* StringWooTests.swift */,
 				B5980A6621AC91AA00EBF596 /* BundleWooTests.swift */,
 				B57C5C9821B80E7100FF82B2 /* DataWooTests.swift */,
 				746FC23C2200A62B00C3096C /* DateWooTests.swift */,
@@ -1985,6 +1988,7 @@
 				B53A569721123D3B000776C9 /* ResultsControllerUIKitTests.swift in Sources */,
 				B57C5C9921B80E7100FF82B2 /* DictionaryWooTests.swift in Sources */,
 				D816DDBC22265DA300903E59 /* OrderTrackingTableViewCellTests.swift in Sources */,
+				D85B833D2230DC9D002168F3 /* StringWooTests.swift in Sources */,
 			);
 			runOnlyForDeploymentPostprocessing = 0;
 		};

WooCommerce/WooCommerceTests/Extensions/StringWooTests.swift

@@ -0,0 +1,24 @@
+import XCTest
+@testable import WooCommerce
+
+
+/// UIURL+Woo: Unit Tests
+///
+import XCTest
+
+final class StringWooTests: XCTestCase {
+    func testURLsWithSchemeRemainUnchanged() {
+        let url = "https://automattic.com"
+        let sanitizedURL = url.addHTTPSSchemeIfNecessary()
+
+        XCTAssertEqual(url, sanitizedURL)
+    }
+
+    func testSchemeIsAddedToURLsWithoutScheme() {
+        let expectedResult = "https://automattic.com"
+        let url = "automattic.com"
+        let sanitizedURL = url.addHTTPSSchemeIfNecessary()
+
+        XCTAssertEqual(sanitizedURL, expectedResult)
+    }
+}