Merge pull request #6197 from woocommerce/issue/6180-refund-card-details-test-improvement

[Mobile Payments] Test fetching charge for Refund Confirmation

Author: joshheald

WooCommerce/Classes/ViewRelated/Orders/Order Details/Issue Refunds/IssueRefundViewModel.swift

@@ -106,8 +106,15 @@ final class IssueRefundViewModel {
 
     private let analytics: Analytics
 
-    init(order: Order, refunds: [Refund], currencySettings: CurrencySettings, analytics: Analytics = ServiceLocator.analytics) {
+    private let stores: StoresManager
+
+    init(order: Order,
+         refunds: [Refund],
+         currencySettings: CurrencySettings,
+         analytics: Analytics = ServiceLocator.analytics,
+         stores: StoresManager = ServiceLocator.stores) {
         self.analytics = analytics
+        self.stores = stores
         let items = Self.filterItems(from: order, with: refunds)
         state = State(order: order, refunds: refunds, itemsToRefund: items, currencySettings: currencySettings)
         sections = createSections()
@@ -246,7 +253,7 @@ private extension IssueRefundViewModel {
             return
         }
         let action = CardPresentPaymentAction.fetchWCPayCharge(siteID: state.order.siteID, chargeID: chargeID, onCompletion: { _ in })
-        ServiceLocator.stores.dispatch(action)
+        stores.dispatch(action)
     }
 }
 

WooCommerce/WooCommerceTests/ViewRelated/Orders/Issue Refund/IssueRefundViewModelTests.swift

@@ -581,4 +581,26 @@ final class IssueRefundViewModelTests: XCTestCase {
         // Then
         XCTAssertFalse(viewModel.isSelectAllButtonVisible)
     }
+
+    func test_viewModel_fetches_charge_before_creating_refundConfirmationViewModel() throws {
+        // Given
+        // The order has a chargeID
+        let order = MockOrders().sampleOrder().copy(chargeID: "ch_id")
+        let stores = MockStoresManager(sessionManager: .makeForTesting(authenticated: true))
+
+        // When
+        let chargeFetched: Bool = waitFor { promise in
+            stores.whenReceivingAction(ofType: CardPresentPaymentAction.self) { action in
+                guard case .fetchWCPayCharge(siteID: _, chargeID: "ch_id", onCompletion: _) = action else {
+                    return
+                }
+                promise(true)
+            }
+
+            _ = IssueRefundViewModel(order: order, refunds: [], currencySettings: CurrencySettings(), stores: stores)
+        }
+
+        // Then
+        XCTAssertTrue(chargeFetched)
+    }
 }