Use OrderFactory.deletedShippingLine to remove shipping line

Author: rachelmcr

WooCommerce/Classes/ViewRelated/Orders/Order Creation/Synchronizer/ShippingInputTransformer.swift

@@ -11,7 +11,7 @@ struct ShippingInputTransformer {
         // If input is `nil`, then we remove any existing shipping line.
         // We remove a shipping like by setting its `methodID` to nil.
         guard let input = input else {
-            let linesToRemove = order.shippingLines.map { $0.copy(methodID: .some(nil), total: "0") }
+            let linesToRemove = order.shippingLines.map { OrderFactory.deletedShippingLine($0) }
             return order.copy(shippingTotal: "0", shippingLines: linesToRemove)
         }
 

Yosemite/Yosemite/Stores/Order/OrderFactory.swift

@@ -74,7 +74,7 @@ public enum OrderFactory {
     /// Creates a shipping line suitable to delete a shipping line already saved remotely in an order.
     ///
     public static func deletedShippingLine(_ shippingLine: ShippingLine) -> ShippingLine {
-        shippingLine.copy(methodID: .some(nil))
+        shippingLine.copy(methodID: .some(nil), total: "0")
     }
 
     /// References a new empty order with constants `Date` values.