Merge pull request #5393 from selanthiraiyan/issue/4142-migrate-settings-screen-to-mvvm

Migrate `Settings` screen to MVVM

Author: itsmeichigo

Storage/Storage/Protocols/StorageManagerType.swift

@@ -16,7 +16,7 @@ public protocol StorageManagerType {
     ///
     var viewStorage: StorageType { get }
 
-    /// Returns the `Storage` associated to the main thread.
+    /// Returns a shared derived storage instance dedicated for write operations.
     ///
     var writerDerivedStorage: StorageType { get }
 

WooCommerce/Classes/ViewRelated/Dashboard/DashboardViewController.swift

@@ -389,7 +389,7 @@ extension DashboardViewController {
 private extension DashboardViewController {
 
     @objc func settingsTapped() {
-        let settingsViewController = SettingsViewController(nibName: nil, bundle: nil)
+        let settingsViewController = SettingsViewController()
         ServiceLocator.analytics.track(.settingsTapped)
         show(settingsViewController, sender: self)
     }