Merge pull request #5859 from woocommerce/fix/5855-ghost-reviews-tabbar

jaclync · web-flow · commit bc0560975a63 · 2022-01-13T09:40:18.000+08:00
Fix ghost "Reviews" label in the tab bar when `hubMenu` feature flag is off
diff --git a/WooCommerce/Classes/ViewRelated/Reviews/ReviewsViewController.swift b/WooCommerce/Classes/ViewRelated/Reviews/ReviewsViewController.swift
@@ -229,7 +229,11 @@ private extension ReviewsViewController {
     }
 
     func refreshTitle() {
-        title = Localization.title
+        if ServiceLocator.featureFlagService.isFeatureFlagEnabled(.hubMenu) {
+            title = Localization.title
+        } else {
+            navigationItem.title = Localization.title
+        }
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -229,7 +229,11 @@ private extension ReviewsViewController {`
`229`	`229`	`}`
`230`	`230`
`231`	`231`	`func refreshTitle() {`
`232`		`- title = Localization.title`
	`232`	`+ if ServiceLocator.featureFlagService.isFeatureFlagEnabled(.hubMenu) {`
	`233`	`+ title = Localization.title`
	`234`	`+ } else {`
	`235`	`+ navigationItem.title = Localization.title`
	`236`	`+ }`
`233`	`237`	`}`
`234`	`238`	`}`
`235`	`239`