Update onOrderCreated closure to onFinished, and added documentation

Author: Ecarrion

WooCommerce/Classes/ViewRelated/Orders/Order Creation/FlowCoordinator/AddOrderCoordinator.swift

@@ -79,7 +79,7 @@ private extension AddOrderCoordinator {
     ///
     func presentNewOrderController() {
         let viewModel = NewOrderViewModel(siteID: siteID)
-        viewModel.onOrderCreated = onOrderCreated
+        viewModel.onFinished = onOrderCreated
 
         let viewController = NewOrderHostingController(viewModel: viewModel)
         if ServiceLocator.featureFlagService.isFeatureFlagEnabled(.splitViewInOrdersTab) {

WooCommerce/Classes/ViewRelated/Orders/Order Creation/NewOrderViewModel.swift

@@ -346,7 +346,7 @@ final class NewOrderViewModel: ObservableObject {
 
             switch result {
             case .success(let newOrder):
-                self.onOrderCreated(newOrder)
+                self.onFinished(newOrder)
                 self.trackCreateOrderSuccess()
             case .failure(let error):
                 self.notice = NoticeFactory.createOrderErrorNotice(error, order: self.orderSynchronizer.order)
@@ -357,9 +357,11 @@ final class NewOrderViewModel: ObservableObject {
         trackCreateButtonTapped()
     }
 
-    /// Assign this closure to be notified when a new order is created
+    /// Assign this closure to be notified when the flow has finished.
+    /// For creation it means that the order has been created.
+    /// For edition it means that the merchant has finished editing the order.
     ///
-    var onOrderCreated: (Order) -> Void = { _ in }
+    var onFinished: (Order) -> Void = { _ in }
 
     /// Updates the order status & tracks its event
     ///

WooCommerce/Classes/ViewRelated/Orders/Order Details/OrderDetailsViewController.swift

@@ -354,7 +354,7 @@ private extension OrderDetailsViewController {
     ///
     private func editOrder() {
         let viewModel = NewOrderViewModel(siteID: viewModel.order.siteID, flow: .editing(initialOrder: viewModel.order))
-        viewModel.onOrderCreated = { [weak self] order in
+        viewModel.onFinished = { [weak self] order in
             guard let self = self else { return }
             self.dismiss(animated: true)
         }