OrdersVM: Rename onShouldResynchronize* block

Mentioning `IfViewIsVisible` is more appripriate now that the block is called
by multiple scenarios in the `ViewModel`.

Author: shiki

WooCommerce/Classes/ViewRelated/Orders/OrdersViewController.swift

@@ -137,7 +137,7 @@ private extension OrdersViewController {
     /// Initialize ViewModel operations
     ///
     func configureViewModel() {
-        viewModel.onShouldResynchronizeAfterAppActivation = { [weak self] in
+        viewModel.onShouldResynchronizeIfViewIsVisible = { [weak self] in
             guard let self = self,
                   // Avoid synchronizing if the view is not visible. The refresh will be handled in
                   // `viewWillAppear` instead.

WooCommerce/Classes/ViewRelated/Orders/OrdersViewModel.swift

@@ -31,9 +31,10 @@ final class OrdersViewModel {
     ///
     private var cancellable: ObservationToken?
 
-    /// The block called if self requests a resynchronization of the first page.
+    /// The block called if self requests a resynchronization of the first page. The
+    /// resynchronization should only be done if the view is visible.
     ///
-    var onShouldResynchronizeAfterAppActivation: (() -> ())?
+    var onShouldResynchronizeIfViewIsVisible: (() -> ())?
 
     /// OrderStatus that must be matched by retrieved orders.
     ///
@@ -143,7 +144,7 @@ final class OrdersViewModel {
         }
 
         isAppActive = true
-        onShouldResynchronizeAfterAppActivation?()
+        onShouldResynchronizeIfViewIsVisible?()
     }
 
     /// Returns what `OrderAction` should be used when synchronizing.
@@ -257,7 +258,7 @@ private extension OrdersViewModel {
                 return
             }
 
-            self?.onShouldResynchronizeAfterAppActivation?()
+            self?.onShouldResynchronizeIfViewIsVisible?()
         }
     }
 

WooCommerce/WooCommerceTests/ViewRelated/Orders/OrdersViewModelTests.swift

@@ -334,7 +334,7 @@ final class OrdersViewModelTests: XCTestCase {
         let viewModel = OrdersViewModel(notificationCenter: notificationCenter, statusFilter: nil)
 
         var resynchronizeRequested = false
-        viewModel.onShouldResynchronizeAfterAppActivation = {
+        viewModel.onShouldResynchronizeIfViewIsVisible = {
             resynchronizeRequested = true
         }
 
@@ -354,7 +354,7 @@ final class OrdersViewModelTests: XCTestCase {
         let viewModel = OrdersViewModel(notificationCenter: notificationCenter, statusFilter: nil)
 
         var resynchronizeRequested = false
-        viewModel.onShouldResynchronizeAfterAppActivation = {
+        viewModel.onShouldResynchronizeIfViewIsVisible = {
             resynchronizeRequested = true
         }
 
@@ -375,7 +375,7 @@ final class OrdersViewModelTests: XCTestCase {
         let viewModel = OrdersViewModel(pushNotificationsManager: pushNotificationsManager, statusFilter: nil)
 
         var resynchronizeRequested = false
-        viewModel.onShouldResynchronizeAfterAppActivation = {
+        viewModel.onShouldResynchronizeIfViewIsVisible = {
             resynchronizeRequested = true
         }
 
@@ -395,7 +395,7 @@ final class OrdersViewModelTests: XCTestCase {
         let viewModel = OrdersViewModel(pushNotificationsManager: pushNotificationsManager, statusFilter: nil)
 
         var resynchronizeRequested = false
-        viewModel.onShouldResynchronizeAfterAppActivation = {
+        viewModel.onShouldResynchronizeIfViewIsVisible = {
             resynchronizeRequested = true
         }