Skip to content

Commit c2b572b

Browse files
committed
Update test for active upload
1 parent 911b07a commit c2b572b

File tree

1 file changed

+6
-16
lines changed

1 file changed

+6
-16
lines changed

WooCommerce/WooCommerceTests/ViewRelated/Products/Media/ProductImageUploaderTests.swift

Lines changed: 6 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -594,26 +594,16 @@ final class ProductImageUploaderTests: XCTestCase {
594594
let uploadedMedia = Media.fake().copy(mediaID: 645)
595595
stores.whenReceivingAction(ofType: MediaAction.self) { action in
596596
if case let .uploadMedia(_, _, _, _, _, onCompletion) = action {
597+
XCTAssertEqual(activeUploads, [key])
597598
onCompletion(.success(uploadedMedia))
598-
}
599-
}
600-
actionHandler.uploadMediaAssetToSiteMediaLibrary(asset: .phAsset(asset: asset))
601-
602-
// Then
603-
waitUntil {
604-
activeUploads == [key]
605-
}
606599

607-
// When
608-
stores.whenReceivingAction(ofType: ProductAction.self) { action in
609-
if case let .updateProductImages(_, _, images, onCompletion) = action {
610-
onCompletion(.success(.fake().copy(images: images)))
600+
// Then
601+
self.waitUntil {
602+
activeUploads == []
603+
}
611604
}
612605
}
613-
imageUploader.saveProductImagesWhenNoneIsPendingUploadAnymore(key: key) { _ in
614-
// Then
615-
XCTAssertEqual(activeUploads, [])
616-
}
606+
actionHandler.uploadMediaAssetToSiteMediaLibrary(asset: .phAsset(asset: asset))
617607
}
618608

619609
func test_product_is_removed_from_activeUploads_when_upload_is_cancelled() {

0 commit comments

Comments
 (0)