Skip to content

Commit c8fc5f6

Browse files
authored
Merge pull request #5311 from woocommerce/feat/upgrade-CI-to-Xcode-13
Change Circle CI image to Xcode 13
2 parents b838761 + 2f66be5 commit c8fc5f6

File tree

6 files changed

+23
-11
lines changed

6 files changed

+23
-11
lines changed

.circleci/config.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,15 @@ parameters:
1515
default: false
1616

1717
xcode_version: &xcode_version
18-
xcode-version: "12.5.0"
18+
xcode-version: "13.0.0"
1919

2020
iphone_test_device: &iphone_test_device
21-
device: iPhone 11
22-
ios-version: "14.4"
21+
device: iPhone 13
22+
ios-version: "15.0"
2323

2424
ipad_test_device: &ipad_test_device
2525
device: iPad Air (4th generation)
26-
ios-version: "14.4"
26+
ios-version: "15.0"
2727

2828
commands:
2929
fix-image:
@@ -38,7 +38,7 @@ commands:
3838
echo "Manually added `/usr/local/bin` to the $PATH:"
3939
echo $PATH
4040
fi
41-
chruby ruby-2.6.6
41+
chruby ruby-$(cat .ruby-version)
4242
gem install bundler
4343
4444
# Add support for fetching SPM packages from GitHub

.ruby-version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
2.6.4
1+
2.7.4

.xcversion

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
12.5
1+
13.0

Scripts/build-phases/generate-credentials.sh

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
#!/usr/bin/env bash -euo pipefail
22

3+
if [[ $ACTION == 'indexbuild' ]]; then
4+
echo "ℹ️: Skipping code generation in 'indexbuild' build. See https://github.com/mac-cain13/R.swift/issues/719#issuecomment-937733804 for more info."
5+
exit 0
6+
fi
7+
38
DERIVED_PATH=${SOURCE_ROOT}/DerivedSources
49
SCRIPT_PATH=${SOURCE_ROOT}/Credentials/replace_secrets.rb
510

WooCommerce/Classes/Extensions/UITabBar+Appearance.swift

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,13 @@ extension UITabBar {
1515
/// To fix it, we have to specifically set it in the `standardAppearance` object.
1616
///
1717
appearance.standardAppearance = createWooTabBarAppearance()
18+
19+
/// This is needed because the tab bar background has the wrong color under iOS 15 (using Xcode 13).
20+
/// More: issue-5018
21+
///
22+
if #available(iOS 15.0, *) {
23+
appearance.scrollEdgeAppearance = appearance.standardAppearance
24+
}
1825
}
1926

2027
/// Creates an appearance object for a tabbar with the default WC style.

WooCommerce/Classes/ViewRelated/ReusableViews/SwiftUI Components/AttributedText.swift

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -197,13 +197,13 @@ extension EnvironmentValues {
197197

198198
private extension EnvironmentValues {
199199
var foregroundColor: Color? {
200-
get { self[ForegroundColorKey] }
201-
set { self[ForegroundColorKey] = newValue }
200+
get { self[ForegroundColorKey.self] }
201+
set { self[ForegroundColorKey.self] = newValue }
202202
}
203203

204204
var linkColor: Color? {
205-
get { self[LinkColorKey] }
206-
set { self[LinkColorKey] = newValue }
205+
get { self[LinkColorKey.self] }
206+
set { self[LinkColorKey.self] = newValue }
207207
}
208208
}
209209

0 commit comments

Comments
 (0)