Remove older needsPayment

Author: Ecarrion

WooCommerce/Classes/ViewModels/Order Details/OrderDetailsViewModel.swift

@@ -751,16 +751,3 @@ extension OrderDetailsViewModel {
         }
     }
 }
-
-private extension Order {
-    /// This check is temporary, we are working on knowing if an order needs payment directly from the API.
-    /// Conditions copied from:
-    /// https://github.com/woocommerce/woocommerce/blob/3611d4643791bad87a0d3e6e73e031bb80447417/plugins/woocommerce/includes/class-wc-order.php#L1520-L1523
-    ///
-    var needsPayment: Bool {
-        guard let total = Double(total) else {
-            return false
-        }
-        return total > .zero && (status == .pending || status == .failed)
-    }
-}

WooCommerce/WooCommerceTests/ViewRelated/OrderDetailsViewModelTests.swift

@@ -95,7 +95,7 @@ final class OrderDetailsViewModelTests: XCTestCase {
 
     func test_there_should_not_be_share_link_action_if_order_is_not_pending_payment() {
         // Given
-        let order = Order.fake().copy(status: .processing, total: "10.0", paymentURL: nil)
+        let order = Order.fake().copy(needsPayment: false, status: .processing, total: "10.0", paymentURL: nil)
 
         // When
         let viewModel = OrderDetailsViewModel(order: order)
@@ -108,7 +108,7 @@ final class OrderDetailsViewModelTests: XCTestCase {
     func test_there_should_be_share_link_action_if_order_is_pending_payment() {
         // Given
         let paymentURL = URL(string: "http://www.automattic.com")
-        let order = Order.fake().copy(status: .pending, total: "10.0", paymentURL: paymentURL)
+        let order = Order.fake().copy(needsPayment: true, status: .pending, total: "10.0", paymentURL: paymentURL)
 
         // When
         let viewModel = OrderDetailsViewModel(order: order)