Fix unit test failures for JetpackConnectionWebViewModelTests

Author: itsmeichigo

WooCommerce/WooCommerceTests/Authentication/JetpackConnectionWebViewModelTests.swift

@@ -18,11 +18,13 @@ final class JetpackConnectionWebViewModelTests: XCTestCase {
         let authorizePolicy = await viewModel.decidePolicy(for: authorizeURL)
         let finalUrl = try XCTUnwrap(URL(string: siteURL + "/wp-admin"))
         let completionPolicy = await viewModel.decidePolicy(for: finalUrl)
+        waitUntil {
+            completionTriggered == true
+        }
 
         // Then
         XCTAssertEqual(authorizePolicy, .allow)
         XCTAssertEqual(completionPolicy, .cancel)
-        XCTAssertTrue(completionTriggered)
     }
 
     func test_dismissal_is_tracked() throws {
@@ -46,13 +48,21 @@ final class JetpackConnectionWebViewModelTests: XCTestCase {
         let analyticsProvider = MockAnalyticsProvider()
         let analytics = WooAnalytics(analyticsProvider: analyticsProvider)
 
+        var completionTriggered = false
+        let completionHandler: () -> Void = {
+            completionTriggered = true
+        }
+
         let siteURL = "https://test.com"
         let initialURL = try XCTUnwrap(URL(string: "https://jetpack.wordpress.com/jetpack.authorize/1/"))
-        let viewModel = JetpackConnectionWebViewModel(initialURL: initialURL, siteURL: siteURL, analytics: analytics, completion: {})
+        let viewModel = JetpackConnectionWebViewModel(initialURL: initialURL, siteURL: siteURL, analytics: analytics, completion: completionHandler)
 
         // When
         let finalUrl = try XCTUnwrap(URL(string: siteURL + "/wp-admin"))
         _ = await viewModel.decidePolicy(for: finalUrl)
+        waitUntil {
+            completionTriggered == true
+        }
 
         // Then
         XCTAssertNotNil(analyticsProvider.receivedEvents.first(where: { $0 == "login_jetpack_connect_completed" }))