Set content shape to rectangle to allow tapping on background without UI elements on top.

jaclync · jaclync · commit d35942c38687 · 2021-11-09T15:02:40.000+08:00
diff --git a/WooCommerce/Classes/ViewRelated/Dashboard/JetpackConnectionPackageSites/JetpackBenefitsBanner.swift b/WooCommerce/Classes/ViewRelated/Dashboard/JetpackConnectionPackageSites/JetpackBenefitsBanner.swift
@@ -56,14 +56,12 @@ struct JetpackBenefitsBanner: View {
             }
             .padding(insets: Layout.padding)
         }
-        .gesture(
-            TapGesture()
-                .onEnded { _ in
-                    self.tapAction()
-                }
-        )
         .background(Color(.jetpackBenefitsBackground))
         .fixedSize(horizontal: false, vertical: true)
+        .contentShape(Rectangle())
+        .onTapGesture {
+            self.tapAction()
+        }
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -56,14 +56,12 @@ struct JetpackBenefitsBanner: View {`
`56`	`56`	`}`
`57`	`57`	`.padding(insets: Layout.padding)`
`58`	`58`	`}`
`59`		`- .gesture(`
`60`		`- TapGesture()`
`61`		`- .onEnded { _ in`
`62`		`- self.tapAction()`
`63`		`- }`
`64`		`- )`
`65`	`59`	`.background(Color(.jetpackBenefitsBackground))`
`66`	`60`	`.fixedSize(horizontal: false, vertical: true)`
	`61`	`+ .contentShape(Rectangle())`
	`62`	`+ .onTapGesture {`
	`63`	`+ self.tapAction()`
	`64`	`+ }`
`67`	`65`	`}`
`68`	`66`	`}`
`69`	`67`