Skip to content

Commit d365fae

Browse files
committed
Add productID to unit tests.
1 parent 2558af9 commit d365fae

File tree

3 files changed

+13
-3
lines changed

3 files changed

+13
-3
lines changed

Networking/NetworkingTests/Remote/MediaRemoteTests.swift

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,10 @@ final class MediaRemoteTests: XCTestCase {
1010
///
1111
let sampleSiteID: Int64 = 1234
1212

13+
/// Dummy Product ID
14+
///
15+
private let sampleProductID: Int64 = 586
16+
1317
/// Repeat always!
1418
///
1519
override func setUp() {
@@ -64,6 +68,7 @@ final class MediaRemoteTests: XCTestCase {
6468
network.simulateResponse(requestUrlSuffix: path, filename: "media-upload")
6569

6670
remote.uploadMedia(for: sampleSiteID,
71+
productID: sampleProductID,
6772
mediaItems: []) { mediaItems, error in
6873
XCTAssertNil(error)
6974
XCTAssertNotNil(mediaItems)
@@ -81,6 +86,7 @@ final class MediaRemoteTests: XCTestCase {
8186
let expectation = self.expectation(description: "Upload one media item")
8287

8388
remote.uploadMedia(for: sampleSiteID,
89+
productID: sampleProductID,
8490
mediaItems: []) { mediaItems, error in
8591
XCTAssertNil(mediaItems)
8692
XCTAssertNotNil(error)

WooCommerce/WooCommerceTests/Mockups/MockMediaStoresManager.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ final class MockMediaStoresManager: DefaultStoresManager {
2626

2727
private func onMediaAction(action: MediaAction) {
2828
switch action {
29-
case .uploadMedia(_, _, let onCompletion):
29+
case .uploadMedia(_, _, _, let onCompletion):
3030
onCompletion(media, nil)
3131
case .retrieveMediaLibrary(_, _, _, let onCompletion):
3232
guard let media = media else {

Yosemite/YosemiteTests/Stores/MediaStoreTests.swift

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,10 @@ final class MediaStoreTests: XCTestCase {
2020
///
2121
private let sampleSiteID: Int64 = 123
2222

23+
/// Testing Product ID
24+
///
25+
private let sampleProductID: Int64 = 586
26+
2327
// MARK: - Overridden Methods
2428

2529
override func setUp() {
@@ -140,7 +144,7 @@ final class MediaStoreTests: XCTestCase {
140144
network.simulateResponse(requestUrlSuffix: path, filename: "media-upload")
141145

142146
let asset = PHAsset()
143-
let action = MediaAction.uploadMedia(siteID: sampleSiteID, mediaAsset: asset) { (uploadedMedia, error) in
147+
let action = MediaAction.uploadMedia(siteID: sampleSiteID, productID: sampleProductID, mediaAsset: asset) { (uploadedMedia, error) in
144148
XCTAssertNotNil(uploadedMedia)
145149
XCTAssertNil(error)
146150

@@ -184,7 +188,7 @@ final class MediaStoreTests: XCTestCase {
184188
network.simulateResponse(requestUrlSuffix: path, filename: "generic_error")
185189

186190
let asset = PHAsset()
187-
let action = MediaAction.uploadMedia(siteID: sampleSiteID, mediaAsset: asset) { (uploadedMedia, error) in
191+
let action = MediaAction.uploadMedia(siteID: sampleSiteID, productID: sampleProductID, mediaAsset: asset) { (uploadedMedia, error) in
188192
XCTAssertNil(uploadedMedia)
189193
XCTAssertNotNil(error)
190194

0 commit comments

Comments
 (0)