Push notification: Request permission only when authenticated (#16428)

Author: itsmeichigo

RELEASE-NOTES.txt

@@ -3,6 +3,7 @@
 
 23.9
 -----
+- [Internal] Moved the request for push notification authorization after login [https://github.com/woocommerce/woocommerce-ios/pull/16428]
 - [*] Fixed possible sync issue in POS (https://github.com/woocommerce/woocommerce-ios/pull/16423)
 
 23.8

WooCommerce/Classes/AppDelegate.swift

@@ -272,6 +272,9 @@ extension AppDelegate {
         #if targetEnvironment(simulator)
             DDLogVerbose("👀 Push Notifications are not supported in the Simulator!")
         #else
+            /// We're sending notifications for logged in state only.
+            /// Revisit this check if a local notification in unauthenticated state is needed.
+            guard stores.isAuthenticated else { return }
             let pushNotesManager = ServiceLocator.pushNotesManager
             pushNotesManager.registerForRemoteNotifications()
             pushNotesManager.ensureAuthorizationIsRequested(includesProvisionalAuth: false, onCompletion: nil)