Cleanup after tests correctly

koke · koke · commit d8c85dcd9ee3 · 2022-02-15T17:18:29.000+01:00
diff --git a/WooCommerce/WooCommerceTests/ViewRelated/CardPresentPayments/CardPresentPaymentsOnboardingUseCaseTests.swift b/WooCommerce/WooCommerceTests/ViewRelated/CardPresentPayments/CardPresentPaymentsOnboardingUseCaseTests.swift
@@ -31,10 +31,12 @@ class CardPresentPaymentsOnboardingUseCaseTests: XCTestCase {
             }
         }
         stores.sessionManager.setStoreId(sampleSiteID)
-        ServiceLocator.setSelectedSiteSettings(.init(stores: stores, storageManager: storageManager))
+        ServiceLocator.setSelectedSiteSettings(SelectedSiteSettings(stores: stores, storageManager: storageManager))
     }
 
     override func tearDownWithError() throws {
+        ServiceLocator.setSelectedSiteSettings(SelectedSiteSettings())
+        storageManager.reset()
         storageManager = nil
         stores = nil
         try super.tearDownWithError()

Original file line number	Diff line number	Diff line change
`@@ -31,10 +31,12 @@ class CardPresentPaymentsOnboardingUseCaseTests: XCTestCase {`
`31`	`31`	`}`
`32`	`32`	`}`
`33`	`33`	`stores.sessionManager.setStoreId(sampleSiteID)`
`34`		`- ServiceLocator.setSelectedSiteSettings(.init(stores: stores, storageManager: storageManager))`
	`34`	`+ ServiceLocator.setSelectedSiteSettings(SelectedSiteSettings(stores: stores, storageManager: storageManager))`
`35`	`35`	`}`
`36`	`36`
`37`	`37`	`override func tearDownWithError() throws {`
	`38`	`+ ServiceLocator.setSelectedSiteSettings(SelectedSiteSettings())`
	`39`	`+ storageManager.reset()`
`38`	`40`	`storageManager = nil`
`39`	`41`	`stores = nil`
`40`	`42`	`try super.tearDownWithError()`