move property to key value

iamgabrielma · iamgabrielma · commit da2729fbabff · 2025-02-13T16:10:21.000+01:00
diff --git a/WooCommerce/Classes/POS/Analytics/WooAnalyticsEvent+PointOfSale.swift b/WooCommerce/Classes/POS/Analytics/WooAnalyticsEvent+PointOfSale.swift
@@ -12,6 +12,7 @@ extension WooAnalyticsEvent {
             static let paymentsOnboardingState = "onboarding_state"
             static let itemType = "product_type"
             static let itemsInCart = "items_in_cart"
+            static let millisecondsSinceCustomerInteractionStarted = "milliseconds_since_customer_interaction_started"
         }
 
         static func paymentsOnboardingShown() -> WooAnalyticsEvent {
@@ -34,7 +35,7 @@ extension WooAnalyticsEvent {
 
         static func cardPresentCollectPaymentSuccess(millisecondsSinceCustomerIteractionStated: Double) -> WooAnalyticsEvent {
             WooAnalyticsEvent(statName: .collectPaymentSuccess, properties: [
-                "milliseconds_since_customer_interaction_started" : "\(millisecondsSinceCustomerIteractionStated)"]
+                Key.millisecondsSinceCustomerInteractionStarted : "\(millisecondsSinceCustomerIteractionStated)"]
             )
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,7 @@ extension WooAnalyticsEvent {`
`12`	`12`	`static let paymentsOnboardingState = "onboarding_state"`
`13`	`13`	`static let itemType = "product_type"`
`14`	`14`	`static let itemsInCart = "items_in_cart"`
	`15`	`+ static let millisecondsSinceCustomerInteractionStarted = "milliseconds_since_customer_interaction_started"`
`15`	`16`	`}`
`16`	`17`
`17`	`18`	`static func paymentsOnboardingShown() -> WooAnalyticsEvent {`
`@@ -34,7 +35,7 @@ extension WooAnalyticsEvent {`
`34`	`35`
`35`	`36`	`static func cardPresentCollectPaymentSuccess(millisecondsSinceCustomerIteractionStated: Double) -> WooAnalyticsEvent {`
`36`	`37`	`WooAnalyticsEvent(statName: .collectPaymentSuccess, properties: [`
`37`		`- "milliseconds_since_customer_interaction_started" : "\(millisecondsSinceCustomerIteractionStated)"]`
	`38`	`+ Key.millisecondsSinceCustomerInteractionStarted : "\(millisecondsSinceCustomerIteractionStated)"]`
`38`	`39`	`)`
`39`	`40`	`}`
`40`	`41`	`}`