OrderSearchStarterVM: Revert empty string and return 0 for total

This matches Android's behavior.

Author: shiki

WooCommerce/Classes/ViewRelated/Search/Order/OrderSearchStarterViewModel.swift

@@ -83,7 +83,7 @@ extension OrderSearchStarterViewModel {
     func cellViewModel(at indexPath: IndexPath) -> CellViewModel {
         let orderStatus = resultsController.object(at: indexPath)
 
-        let total = orderStatus.total > 0 ? NumberFormatter.localizedUpToNinetyNine(orderStatus.total) : ""
+        let total = NumberFormatter.localizedUpToNinetyNine(orderStatus.total)
 
         return CellViewModel(name: orderStatus.name ?? "",
                              slug: orderStatus.slug,

WooCommerce/WooCommerceTests/ViewRelated/Search/Order/OrderSearchStarterViewModelTests.swift

@@ -104,21 +104,6 @@ final class OrderSearchStarterViewModelTests: XCTestCase {
         // Then
         XCTAssertEqual(cellViewModel.total, NSLocalizedString("99+", comment: ""))
     }
-
-    func testGivenAnOrderStatusTotalOfZeroItReturnsAnEmptyString() {
-        // Given
-        let viewModel = OrderSearchStarterViewModel(siteID: siteID, storageManager: storageManager)
-
-        insert(OrderStatus(name: "Processing", siteID: siteID, slug: "slug", total: 0))
-
-        viewModel.activateAndForwardUpdates(to: UITableView())
-
-        // When
-        let cellViewModel = viewModel.cellViewModel(at: IndexPath(row: 0, section: 0))
-
-        // Then
-        XCTAssertEqual(cellViewModel.total, "")
-    }
 }
 
 // MARK: - Helpers