Update tests to match changes to flow

Author: joshheald

WooCommerce/WooCommerceTests/Mocks/MockOrderDetailsPaymentAlerts.swift

@@ -6,6 +6,8 @@ final class MockOrderDetailsPaymentAlerts {
     // Public closures to mock alert actions and properties for assertions.
     var cancelReaderIsReadyAlert: (() -> Void)?
 
+    var cancelPreparingReaderAlert: (() -> Void)?
+
     var cancelTapOrInsertCardAlert: (() -> Void)?
 
     var error: Error?
@@ -19,6 +21,10 @@ final class MockOrderDetailsPaymentAlerts {
 }
 
 extension MockOrderDetailsPaymentAlerts: OrderDetailsPaymentAlertsProtocol {
+    func preparingReader(onCancel: @escaping () -> Void) {
+        cancelPreparingReaderAlert = onCancel
+    }
+
     func presentViewModel(viewModel: CardPresentPaymentsModalViewModel) {
         // no-op
     }

WooCommerce/WooCommerceTests/ViewModels/CardPresentPayments/CollectOrderPaymentUseCaseTests.swift

@@ -43,7 +43,7 @@ final class CollectOrderPaymentUseCaseTests: XCTestCase {
         super.tearDown()
     }
 
-    func test_cancelling_readerIsReady_alert_triggers_onCancel_and_tracks_collectPaymentCanceled_event_and_dispatches_cancel_action() throws {
+    func test_cancelling_preparingReader_alert_triggers_onCancel_and_tracks_collectPaymentCanceled_event_and_dispatches_cancel_action() throws {
         // Given
         assertEmpty(stores.receivedActions)
 
@@ -53,7 +53,7 @@ final class CollectOrderPaymentUseCaseTests: XCTestCase {
             self.useCase.collectPayment(onCollect: { _ in }, onCancel: {
                 promise(())
             }, onCompleted: {})
-            self.alerts.cancelReaderIsReadyAlert?()
+            self.alerts.cancelPreparingReaderAlert?()
         }
 
         // Then
@@ -243,6 +243,17 @@ private extension CollectOrderPaymentUseCaseTests {
                 completion([MockCardReader.wisePad3()])
             } else if case let .cancelPayment(completion) = action {
                 completion?(.success(()))
+            } else if case let .collectPayment(_, _, _, onCardReaderMessage, _, _) = action {
+                onCardReaderMessage(.waitingForInput(""))
+            }
+        }
+
+        stores.whenReceivingAction(ofType: SystemStatusAction.self) { action in
+            switch action {
+            case .synchronizeSystemPlugins(_, let completion):
+                completion(.success(()))
+            default:
+                break
             }
         }
     }

WooCommerce/WooCommerceTests/ViewModels/CardPresentPayments/RefundSubmissionUseCaseTests.swift

@@ -356,7 +356,7 @@ final class RefundSubmissionUseCaseTests: XCTestCase {
         XCTAssertEqual(eventProperties["plugin_slug"] as? String, Mocks.paymentGatewayID)
     }
 
-    func test_canceling_readerIsReady_alert_tracks_interacRefundCanceled_event_when_payment_method_is_interac() throws {
+    func test_canceling_preparingReader_alert_tracks_interacRefundCanceled_event_when_payment_method_is_interac() throws {
         // Given
         let useCase = createUseCase(details: .init(order: .fake().copy(total: "2.28"),
                                                    charge: .fake().copy(paymentMethodDetails: .interacPresent(
@@ -376,42 +376,7 @@ final class RefundSubmissionUseCaseTests: XCTestCase {
             useCase.submitRefund(.fake(), showInProgressUI: {}, onCompletion: { result in
                 promise(result)
             })
-            self.alerts.cancelReaderIsReadyAlert?()
-        }
-
-        // Then
-        XCTAssertTrue(result.isFailure)
-        XCTAssertEqual(result.failure as? RefundSubmissionUseCase.RefundSubmissionError, .canceledByUser)
-
-        let indexOfEvent = try XCTUnwrap(analyticsProvider.receivedEvents.firstIndex(where: { $0 == "interac_refund_cancelled"}))
-        let eventProperties = try XCTUnwrap(analyticsProvider.receivedProperties[indexOfEvent])
-        XCTAssertEqual(eventProperties["card_reader_model"] as? String, Mocks.cardReaderModel)
-        XCTAssertEqual(eventProperties["country"] as? String, "US")
-        XCTAssertEqual(eventProperties["plugin_slug"] as? String, Mocks.paymentGatewayID)
-    }
-
-    func test_canceling_tapOrInsertCard_alert_tracks_interacRefundCanceled_event_when_payment_method_is_interac() throws {
-        // Given
-        let useCase = createUseCase(details: .init(order: .fake().copy(total: "2.28"),
-                                                   charge: .fake().copy(paymentMethodDetails: .interacPresent(
-                                                    details: .init(brand: .visa,
-                                                                   last4: "9969",
-                                                                   funding: .credit,
-                                                                   receipt: .init(accountType: .credit,
-                                                                                  applicationPreferredName: "Stripe Credit",
-                                                                                  dedicatedFileName: "A000000003101001")))),
-                                                   amount: "2.28",
-                                                   paymentGatewayAccount: createPaymentGatewayAccount(siteID: Mocks.siteID)))
-        mockCardPresentPaymentActions(clientSideRefundResult: .failure(RefundSubmissionUseCase.RefundSubmissionError.cardReaderDisconnected),
-                                      cancelRefundResult: .success(()),
-                                      returnCardReaderMessage: .waitingForInput(""))
-
-        // When
-        let result: Result<Void, Error> = waitFor { promise in
-            useCase.submitRefund(.fake(), showInProgressUI: {}, onCompletion: { result in
-                promise(result)
-            })
-            self.alerts.cancelTapOrInsertCardAlert?()
+            self.alerts.cancelPreparingReaderAlert?()
         }
 
         // Then