Merge pull request #4989 from woocommerce/issue/3134-product-image-keeps-loading-on-product-image-upload-error

pmusolino · web-flow · commit deef9160b857 · 2021-09-15T11:04:58.000+02:00
Add/Edit Products: product image stops loading on product image upload error
diff --git a/RELEASE-NOTES.txt b/RELEASE-NOTES.txt
@@ -2,7 +2,7 @@
 
 7.6
 -----
-
+- [*] Fix: when product image upload fails, the image cell stop loading. [https://github.com/woocommerce/woocommerce-ios/pull/4989]
 
 7.5
 -----
diff --git a/WooCommerce/Classes/ViewRelated/Products/Edit Product/ProductFormViewController.swift b/WooCommerce/Classes/ViewRelated/Products/Edit Product/ProductFormViewController.swift
@@ -122,9 +122,7 @@ final class ProductFormViewController<ViewModel: ProductFormViewModelProtocol>:
                 self.displayErrorAlert(title: title, message: message)
             }
 
-            if productImageStatuses.hasPendingUpload {
-                self.onImageStatusesUpdated(statuses: productImageStatuses)
-            }
+            self.onImageStatusesUpdated(statuses: productImageStatuses)
 
             self.viewModel.updateImages(productImageStatuses.images)
         }

-Original file line number
+Diff line change
 .6
 -----
+-
 +- [*] Fix: when product image upload fails, the image cell stop loading. [https://github.com/woocommerce/woocommerce-ios/pull/4989]
 .5
 -----
Original file line number	Diff line number	Diff line change
`@@ -122,9 +122,7 @@ final class ProductFormViewController<ViewModel: ProductFormViewModelProtocol>:`
`122`	`122`	`self.displayErrorAlert(title: title, message: message)`
`123`	`123`	`}`
`124`	`124`
`125`		`- if productImageStatuses.hasPendingUpload {`
`126`		`- self.onImageStatusesUpdated(statuses: productImageStatuses)`
`127`		`- }`
	`125`	`+ self.onImageStatusesUpdated(statuses: productImageStatuses)`
`128`	`126`
`129`	`127`	`self.viewModel.updateImages(productImageStatuses.images)`
`130`	`128`	`}`