OrderTaxLine tests in OrdersUpsertUseCaseTests

- Remove `makeOrderTaxLine()` method and `.fake()` to generate tax lines.

Author: Sharma Elanthiriayan

Yosemite/YosemiteTests/Stores/Order/OrdersUpsertUseCaseTests.swift

@@ -123,7 +123,7 @@ final class OrdersUpsertUseCaseTests: XCTestCase {
 
     func test_it_persists_order_tax_line_in_storage() throws {
         // Given
-        let taxLine = makeOrderTaxLine().copy(taxID: 1)
+        let taxLine = OrderTaxLine.fake().copy(taxID: 1)
         let order = makeOrder().copy(siteID: 3, taxes: [taxLine])
         let useCase = OrdersUpsertUseCase(storage: viewStorage)
 
@@ -137,13 +137,13 @@ final class OrdersUpsertUseCaseTests: XCTestCase {
 
     func test_it_replaces_existing_order_tax_line_in_storage() throws {
         // Given
-        let originalTaxLine = makeOrderTaxLine().copy(taxID: 1, ratePercent: 0.0)
+        let originalTaxLine = OrderTaxLine.fake().copy(taxID: 1, ratePercent: 0.0)
         let order = makeOrder().copy(siteID: 3, taxes: [originalTaxLine])
         let useCase = OrdersUpsertUseCase(storage: viewStorage)
         useCase.upsert([order])
 
         // When
-        let taxLine = makeOrderTaxLine().copy(taxID: 1, ratePercent: 5.0)
+        let taxLine = OrderTaxLine.fake().copy(taxID: 1, ratePercent: 5.0)
         useCase.upsert([order.copy(taxes: [taxLine])])
 
         // Then
@@ -257,16 +257,4 @@ private extension OrdersUpsertUseCaseTests {
               totalTax: "0.00",
               attributes: attributes)
     }
-
-    func makeOrderTaxLine() -> Networking.OrderTaxLine {
-        .init(taxID: 0,
-              rateCode: "TAX",
-              rateID: 0,
-              label: "Tax label",
-              isCompoundTaxRate: true,
-              totalTax: "0.0",
-              totalShippingTax: "0.0",
-              ratePercent: 0.0,
-              attributes: [])
-    }
 }