Skip to content

Commit e7cbe30

Browse files
committed
Remove unnecessary tearDown(). Remove Unit Tests
1 parent 6f8af79 commit e7cbe30

File tree

1 file changed

+3
-47
lines changed

1 file changed

+3
-47
lines changed

Yosemite/YosemiteTests/Stores/CustomerStoreTests.swift

Lines changed: 3 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -26,18 +26,9 @@ class CustomerStoreTests: XCTestCase {
2626
)
2727
}
2828

29-
override func tearDown() {
30-
dispatcher = nil
31-
storageManager = nil
32-
network = nil
33-
remote = nil
34-
store = nil
35-
super.tearDown()
36-
}
37-
3829
func test_retrieveCustomer_returns_Customer_upon_success() {
3930
// Given
40-
network.simulateResponse(requestUrlSuffix: "customers/\(dummyCustomerID)", filename: "customer")
31+
network.simulateResponse(requestUrlSuffix: "", filename: "customer")
4132

4233
// When
4334
let result: Result<Customer, Error> = waitFor { promise in
@@ -51,45 +42,10 @@ class CustomerStoreTests: XCTestCase {
5142
XCTAssertTrue(result.isSuccess)
5243
}
5344

54-
func test_retrieveCustomer_returns_notFound_Error_upon_siteID_error() {
55-
// Given
56-
let expectedError = NetworkError.notFound
57-
network.simulateError(requestUrlSuffix: "customers/\(dummyCustomerID)", error: expectedError)
58-
59-
// When
60-
let result: Result<Customer, Error> = waitFor { promise in
61-
let action = CustomerAction.retrieveCustomer(siteID: 999, customerID: self.dummyCustomerID) { result in
62-
promise(result)
63-
}
64-
self.store.onAction(action)
65-
}
66-
67-
// Then
68-
XCTAssertTrue(result.isFailure)
69-
XCTAssertEqual(result.failure as? NetworkError, expectedError)
70-
}
71-
72-
func test_retrieveCustomer_returns_Error_upon_customerID_error() {
73-
let expectedError = NetworkError.notFound
74-
network.simulateError(requestUrlSuffix: "customers/999", error: expectedError )
75-
76-
// When
77-
let result: Result<Customer, Error> = waitFor { promise in
78-
let action = CustomerAction.retrieveCustomer(siteID: self.dummySiteID, customerID: self.dummyCustomerID) { result in
79-
promise(result)
80-
}
81-
self.store.onAction(action)
82-
}
83-
84-
// Then
85-
XCTAssertTrue(result.isFailure)
86-
XCTAssertEqual(result.failure as? NetworkError, expectedError)
87-
}
88-
89-
func test_retrieveCustomer_returns_notFound_Error_upon_network_error() {
45+
func test_retrieveCustomer_returns_Error_upon_failure() {
9046
// Given
9147
let expectedError = NetworkError.notFound
92-
network.simulateError(requestUrlSuffix: "customers/\(dummyCustomerID)", error: expectedError)
48+
network.simulateError(requestUrlSuffix: "", error: expectedError)
9349

9450
// When
9551
let result: Result<Customer, Error> = waitFor { promise in

0 commit comments

Comments
 (0)