Shipping Labels: Prevent label purchase without payment methods (#15752)

Author: itsmeichigo

WooCommerce/Classes/ViewRelated/Orders/Order Details/Shipping Labels/WooShipping Create Shipping Labels/WooShippingCreateLabelsView.swift

@@ -39,7 +39,6 @@ struct WooShippingCreateLabelsView: View {
 
     @State private var showingCustomsForm = false
     @State private var showingSplitShipments = false
-    @State private var showingPaymentMethods = false
 
     /// Whether the destination address is verified.
     private var isDestinationAddressVerified: Bool {
@@ -106,12 +105,12 @@ struct WooShippingCreateLabelsView: View {
                     isShipmentDetailsExpanded = false
                 }
             }
-            .sheet(isPresented: $showingPaymentMethods) {
+            .sheet(isPresented: $viewModel.showingPaymentMethods) {
                 if let paymentMethodsViewModel = viewModel.paymentMethodsViewModel {
                     WooShippingPaymentMethodsView(viewModel: paymentMethodsViewModel,
                                                   onAccountSettingsUpdate: { settings in
                         viewModel.didUpdateAccountSettings(settings)
-                        showingPaymentMethods = false
+                        viewModel.showingPaymentMethods = false
                     })
                     .presentationDetents([.fraction(0.7), .large])
                 }
@@ -468,7 +467,7 @@ private extension WooShippingCreateLabelsView {
 
     var addPaymentMethodLine: some View {
         Button(action: {
-            showingPaymentMethods = true
+            viewModel.showingPaymentMethods = true
         }) {
             HStack {
                 Image(systemName: "plus")
@@ -487,7 +486,7 @@ private extension WooShippingCreateLabelsView {
         _ cardLineViewModel: WooShippingPaymentMethodLine.CardPaymentMethodLineViewModel
     ) -> some View {
         Button(action: {
-            showingPaymentMethods = true
+            viewModel.showingPaymentMethods = true
         }) {
             HStack {
                 Text(cardLineViewModel.title)

WooCommerce/Classes/ViewRelated/Orders/Order Details/Shipping Labels/WooShipping Create Shipping Labels/WooShippingCreateLabelsViewModel.swift

@@ -182,6 +182,7 @@ final class WooShippingCreateLabelsViewModel: ObservableObject {
     /// Closure to execute after the label is successfully purchased.
     let onLabelPurchase: ((_ markOrderComplete: Bool) -> Void)?
 
+    @Published var showingPaymentMethods = false
     @Published private var paymentMethod: ShippingLabelPaymentMethod?
     @Published private(set) var paymentMethodLine: WooShippingPaymentMethodLine?
 
@@ -296,6 +297,10 @@ final class WooShippingCreateLabelsViewModel: ObservableObject {
     /// Purchases a shipping label with the provided label details and settings.
     @MainActor
     func purchaseLabel(shouldRefreshPackageAndRate: Bool) async {
+        guard paymentMethod != nil else {
+            showingPaymentMethods = true
+            return
+        }
         isPurchasingLabel = true
         labelPurchaseErrorNotice = nil