Remove prints added for debugging

Author: allendav

Hardware/Hardware/CardReader/StripeCardReader/StripeCardReaderService.swift

@@ -256,10 +256,8 @@ extension StripeCardReaderService: CardReaderService {
     }
 
     public func connect(_ reader: CardReader) -> AnyPublisher<CardReader, Error> {
-        print("==== in SCRS connect 1")
         guard let stripeReader = self.discoveredStripeReadersCache.reader(matching: reader) as? Reader else {
             return Future() { promise in
-                print("==== in SCRS connect 1 - unable to find reader in cache")
                 promise(.failure(CardReaderServiceError.connection()))
             }.eraseToAnyPublisher()
         }
@@ -270,7 +268,6 @@ extension StripeCardReaderService: CardReaderService {
     }
 
     private func getBluetoothConfiguration(_ reader: StripeTerminal.Reader) -> Future<BluetoothConnectionConfiguration, Error> {
-        print("==== in SCRS getBluetoothConfiguration")
         return Future() { [weak self] promise in
             guard let self = self else {
                 promise(.failure(CardReaderServiceError.connection()))
@@ -282,10 +279,8 @@ extension StripeCardReaderService: CardReaderService {
             self.readerLocationProvider?.fetchDefaultLocationID { result in
                 switch result {
                 case .success(let locationId):
-                    print("==== in SCRS getBluetoothConfiguration successfully fetched location ID")
                     return promise(.success(BluetoothConnectionConfiguration(locationId: locationId)))
                 case .failure(let error):
-                    print("==== in SCRS getBluetoothConfiguration unable to fetch location ID")
                     let underlyingError = UnderlyingError(with: error)
                     return promise(.failure(CardReaderServiceError.connection(underlyingError: underlyingError)))
                 }
@@ -294,7 +289,6 @@ extension StripeCardReaderService: CardReaderService {
     }
 
     public func connect(_ reader: StripeTerminal.Reader, configuration: BluetoothConnectionConfiguration) -> Future <CardReader, Error> {
-        print("==== in SCRS connect 2")
         // Keep a copy of the battery level in case the connection fails due to low battery
         // If that happens, the reader object won't be accessible anymore, and we want to show
         // the current charge percentage if possible
@@ -307,7 +301,6 @@ extension StripeCardReaderService: CardReaderService {
                 return
             }
 
-            print("==== in SCRS connect 2 about to call Terminal connectBluetoothReader")
             Terminal.shared.connectBluetoothReader(reader, delegate: self, connectionConfig: configuration) { [weak self] (reader, error) in
                 guard let self = self else {
                     promise(.failure(CardReaderServiceError.connection()))
@@ -317,7 +310,6 @@ extension StripeCardReaderService: CardReaderService {
                 self.discoveredStripeReadersCache.clear()
 
                 if let error = error {
-                    print("==== in SCRS connect 2 - got an error: \(error)")
                     let underlyingError = UnderlyingError(with: error)
                     // Starting with StripeTerminal 2.0, required software updates happen transparently on connection
                     // Any error related to that will be reported here, but we don't want to treat it as a connection error
@@ -328,7 +320,6 @@ extension StripeCardReaderService: CardReaderService {
                 }
 
                 if let reader = reader {
-                    print("==== in SCRS connect 2 - got a reader :)")
                     self.connectedReadersSubject.send([CardReader(reader: reader)])
                     self.switchStatusToIdle()
                     promise(.success(CardReader(reader: reader)))

WooCommerce/Classes/ViewRelated/Dashboard/Settings/In-Person Payments/CardPresentPaymentsOnboardingUseCase.swift

@@ -79,13 +79,11 @@ final class CardPresentPaymentsOnboardingUseCase: CardPresentPaymentsOnboardingU
         /// If both plugins are active, don't bother initializing the backend nor fetching
         /// accounts. Fall through to updateState so the end user can fix the problem.
         guard !bothPluginsInstalledAndActive(wcPay: wcPayPlugin, stripe: stripePlugin) else {
-            print("==== in updateAccounts - both WCPay and Stripe are active - bailing")
             self.updateState()
             return
         }
 
         if wcPayPlugin?.active ?? false {
-            print("==== in updateAccounts - WCPay is active on store - informing CPPS")
             let useWCPayAction = CardPresentPaymentAction.useWCPay // TODO asynchronicity / ordering of actions?
             stores.dispatch(useWCPayAction)
         } else {
@@ -97,12 +95,10 @@ final class CardPresentPaymentsOnboardingUseCase: CardPresentPaymentsOnboardingU
         }
 
         if stripePlugin?.active ?? false {
-            print("==== in updateAccounts - Stripe is active on store - informing CPPS")
             let useStripeAction = CardPresentPaymentAction.useStripe // TODO asynchronicity / ordering of actions?
             stores.dispatch(useStripeAction)
         }
 
-        print("==== in updateAccounts - asking CPPS to load account")
         let paymentGatewayAccountsAction = CardPresentPaymentAction.loadAccounts(siteID: siteID) { [weak self] result in
             self?.updateState()
         }
@@ -176,107 +172,82 @@ private extension CardPresentPaymentsOnboardingUseCase {
             DDLogError("[CardPresentPaymentsOnboarding] Couldn't determine country for store")
             return .genericError
         }
-        print("==== was able to obtain country code")
 
         guard isCountrySupported(countryCode: countryCode) else {
             return .countryNotSupported(countryCode: countryCode)
         }
-        print("==== country code is supported")
 
         let wcPay = getWCPayPlugin()
         guard stripeGatewayIPPEnabled == true else {
-            print("==== Stripe IPP experiment is NOT enabled - only considering WCPay")
             return wcPayOnlyOnboardingState(plugin: wcPay)
         }
 
-        print("==== Stripe IPP experiment IS enabled")
         let stripe = getStripePlugin()
 
         // If both the Stripe plugin and WCPay are installed and activated, the user needs
         // to deactivate one: pdfdoF-fW-p2#comment-683
         if bothPluginsInstalledAndActive(wcPay: wcPay, stripe: stripe) {
-            print("==== Both plugins are active - bailing")
             return .selectPlugin
         }
 
         // If only the Stripe extension is active, skip to checking plugin version
         if let stripe = stripe,
             onlyStripeIsActive(wcPay: wcPay, stripe: stripe) {
-            print("==== Only Stripe is active")
             return stripeGatewayOnlyOnboardingState(plugin: stripe)
         } else {
-            print("==== Only WCPay is active")
             return wcPayOnlyOnboardingState(plugin: wcPay)
         }
     }
 
     func wcPayOnlyOnboardingState(plugin: SystemPlugin?) -> CardPresentPaymentOnboardingState {
-        print("==== Checking WCPay plugin version")
         // Plugin checks
         guard let plugin = plugin else {
-            print("==== Checking WCPay plugin installation - plugin is NOT installed!")
             return .pluginNotInstalled
         }
         guard isWCPayVersionSupported(plugin: plugin) else {
-            print("==== Checking WCPay plugin version - plugin version is unsupported")
             return .pluginUnsupportedVersion
         }
         guard plugin.active else {
-            print("==== Checking WCPay plugin activation - plugin is NOT active!")
             return .pluginNotActivated
         }
 
         // Account checks
-        print("==== Checking Stripe plugin version - plugin version is good - proceeding to account check")
         return accountChecks()
     }
 
     func stripeGatewayOnlyOnboardingState(plugin: SystemPlugin) -> CardPresentPaymentOnboardingState {
-        print("==== Checking Stripe plugin version")
         guard isStripeVersionSupported(plugin: plugin) else {
-            print("==== Checking Stripe plugin version - plugin version is unsupported")
             return .pluginUnsupportedVersion
         }
-        print("==== Checking Stripe plugin version - plugin version is good - proceeding to account check")
         return accountChecks()
     }
 
     func accountChecks() -> CardPresentPaymentOnboardingState {
-        print("==== In accountChecks")
         guard let account = getPaymentGatewayAccount() else {
-            print("==== accountChecks genericError")
             return .genericError
         }
         guard isPaymentGatewaySetupCompleted(account: account) else {
-            print("==== accountChecks pluginSetupNotCompleted")
             return .pluginSetupNotCompleted
         }
         guard !isPluginInTestModeWithLiveStripeAccount(account: account) else {
-            print("==== accountChecks pluginInTestModeWithLiveStripeAccount")
             return .pluginInTestModeWithLiveStripeAccount
         }
         guard !isStripeAccountUnderReview(account: account) else {
-            print("==== accountChecks stripeAccountUnderReview")
             return .stripeAccountUnderReview
         }
         guard !isStripeAccountOverdueRequirements(account: account) else {
-            print("==== accountChecks stripeAccountOverdueRequirement")
             return .stripeAccountOverdueRequirement
         }
         guard !isStripeAccountPendingRequirements(account: account) else {
-            print("==== accountChecks stripeAccountPendingRequirement")
             return .stripeAccountPendingRequirement(deadline: account.currentDeadline)
         }
         guard !isStripeAccountRejected(account: account) else {
-            print("==== accountChecks stripeAccountRejected")
             return .stripeAccountRejected
         }
         guard !isInUndefinedState(account: account) else {
-            print("==== accountChecks genericError 2")
             return .genericError
         }
 
-        print("==== accountChecks completed")
         return .completed
     }
 }