Skip to content

Commit f0cb8d1

Browse files
committed
Replace CTA in collect cash view with POSButtonStyle.
1 parent 0e7db67 commit f0cb8d1

File tree

3 files changed

+8
-62
lines changed

3 files changed

+8
-62
lines changed

WooCommerce/Classes/POS/Presentation/PointOfSaleCollectCashView.swift

Lines changed: 8 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -73,24 +73,17 @@ struct PointOfSaleCollectCashView: View {
7373
await submitCashAmount()
7474
}
7575
}, label: {
76-
ZStack {
77-
if isLoading {
78-
ProgressView()
79-
.progressViewStyle(CircularProgressViewStyle())
80-
.tint(Color.posOnInverseSurface)
81-
} else {
82-
Text(Localization.markPaymentCompletedButtonTitle)
83-
.font(Constants.buttonFont)
84-
}
76+
if isLoading {
77+
ProgressView()
78+
.progressViewStyle(CircularProgressViewStyle())
79+
.tint(Color.posOnInverseSurface)
80+
} else {
81+
Text(Localization.markPaymentCompletedButtonTitle)
82+
.font(Constants.buttonFont)
8583
}
86-
.frame(maxWidth: .infinity, minHeight: Constants.buttonMinHeight)
8784
})
88-
.adaptiveButtonPadding(Constants.buttonPadding)
85+
.buttonStyle(POSButtonStyle(variant: .filled, size: .normal))
8986
.frame(maxWidth: .infinity)
90-
.foregroundColor(colorScheme == .light ? Color.white : Color.black)
91-
.background(Color.posPrimaryButtonBackground)
92-
.cornerRadius(Constants.buttonCornerRadius)
93-
.contentShape(Rectangle())
9487
.dynamicTypeSize(...DynamicTypeSize.accessibility1)
9588
.disabled(isLoading)
9689

@@ -170,8 +163,6 @@ private extension PointOfSaleCollectCashView {
170163
@available(iOS 17.0, *)
171164
private extension PointOfSaleCollectCashView {
172165
enum Constants {
173-
static let buttonSpacing: CGFloat = 12
174-
static let buttonPadding: CGFloat = 32
175166
static let buttonMinHeight: CGFloat = 32
176167
static let navigationButtonSpacing: CGFloat = 8
177168
static let navigationHeaderTopPadding: CGFloat = 8

WooCommerce/Classes/POS/Utils/AdaptiveButtonPaddingModifier.swift

Lines changed: 0 additions & 41 deletions
This file was deleted.

WooCommerce/WooCommerce.xcodeproj/project.pbxproj

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1621,7 +1621,6 @@
16211621
68E674AB2A4DAB8C0034BA1E /* CompletedUpgradeView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 68E674AA2A4DAB8C0034BA1E /* CompletedUpgradeView.swift */; };
16221622
68E674AD2A4DAC010034BA1E /* CurrentPlanDetailsView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 68E674AC2A4DAC010034BA1E /* CurrentPlanDetailsView.swift */; };
16231623
68E674AF2A4DACD50034BA1E /* UpgradeTopBarView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 68E674AE2A4DACD50034BA1E /* UpgradeTopBarView.swift */; };
1624-
68E8C04C2D4285C50094FCAC /* AdaptiveButtonPaddingModifier.swift in Sources */ = {isa = PBXBuildFile; fileRef = 68E8C04B2D4285C30094FCAC /* AdaptiveButtonPaddingModifier.swift */; };
16251624
68E952CC287536010095A23D /* SafariView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 68E952CB287536010095A23D /* SafariView.swift */; };
16261625
68E952D0287587BF0095A23D /* CardReaderManualRowView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 68E952CF287587BF0095A23D /* CardReaderManualRowView.swift */; };
16271626
68E952D22875A44B0095A23D /* CardReaderType+Manual.swift in Sources */ = {isa = PBXBuildFile; fileRef = 68E952D12875A44B0095A23D /* CardReaderType+Manual.swift */; };
@@ -4767,7 +4766,6 @@
47674766
68E674AA2A4DAB8C0034BA1E /* CompletedUpgradeView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CompletedUpgradeView.swift; sourceTree = "<group>"; };
47684767
68E674AC2A4DAC010034BA1E /* CurrentPlanDetailsView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CurrentPlanDetailsView.swift; sourceTree = "<group>"; };
47694768
68E674AE2A4DACD50034BA1E /* UpgradeTopBarView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = UpgradeTopBarView.swift; sourceTree = "<group>"; };
4770-
68E8C04B2D4285C30094FCAC /* AdaptiveButtonPaddingModifier.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AdaptiveButtonPaddingModifier.swift; sourceTree = "<group>"; };
47714769
68E952CB287536010095A23D /* SafariView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SafariView.swift; sourceTree = "<group>"; };
47724770
68E952CF287587BF0095A23D /* CardReaderManualRowView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CardReaderManualRowView.swift; sourceTree = "<group>"; };
47734771
68E952D12875A44B0095A23D /* CardReaderType+Manual.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "CardReaderType+Manual.swift"; sourceTree = "<group>"; };
@@ -7151,7 +7149,6 @@
71517149
026826972BF59D9E0036F959 /* Utils */ = {
71527150
isa = PBXGroup;
71537151
children = (
7154-
68E8C04B2D4285C30094FCAC /* AdaptiveButtonPaddingModifier.swift */,
71557152
026826982BF59DA80036F959 /* Color+WooCommercePOS.swift */,
71567153
68E4E8B42C0EF39D00CFA0C3 /* PreviewHelpers.swift */,
71577154
DA4104392C247B6900E8456A /* PointOfSalePreviewOrderController.swift */,
@@ -15774,7 +15771,6 @@
1577415771
01BB6C072D09DC560094D55B /* CardPresentModalLocationPreAlert.swift in Sources */,
1577515772
74B5713621CD7604008F9B8E /* SharingHelper.swift in Sources */,
1577615773
261F1A7929C2AB2E001D9861 /* FreeTrialBannerViewModel.swift in Sources */,
15777-
68E8C04C2D4285C50094FCAC /* AdaptiveButtonPaddingModifier.swift in Sources */,
1577815774
DEF657A82C895B0500ACD61E /* BlazeCampaignObjectivePickerViewModel.swift in Sources */,
1577915775
0313651328ABCB2D00EEE571 /* InPersonPaymentsOnboardingErrorMainContentView.swift in Sources */,
1578015776
B9F148962AD55326008FC795 /* FormattableAmountTextField.swift in Sources */,

0 commit comments

Comments
 (0)