Consolidate title and detail text colors in PointOfSaleItemListCardConstants.

Author: jaclync

WooCommerce/Classes/POS/Presentation/Item Selector/ParentProductCardView.swift

@@ -28,12 +28,12 @@ struct ParentProductCardView: View {
             VStack(alignment: .leading, spacing: Constants.textSpacing) {
                 Text(name)
                     .lineLimit(2)
-                    .foregroundStyle(Color.posPrimaryText)
+                    .foregroundStyle(Constants.titleColor)
                     .multilineTextAlignment(.leading)
                     .font(Constants.itemTitleFont)
 
                 Text(detailText)
-                    .foregroundStyle(Color.posSecondaryText)
+                    .foregroundStyle(Constants.detailColor)
                     .font(Constants.itemDetailFont)
             }
             .padding(.horizontal, Constants.horizontalTextPadding * (1 / scale))

WooCommerce/Classes/POS/Presentation/Item Selector/PointOfSaleItemListCardConstants.swift

@@ -13,4 +13,6 @@ enum PointOfSaleItemListCardConstants {
     static let accessoryButtonMaxWidth: CGFloat = 136
     static let accessoryButtonPadding: CGFloat = 16
     static let backgroundColor: Color = .posSurfaceContainerLowest
+    static let titleColor: Color = .posOnSurface
+    static let detailColor: Color = .posOnSurfaceVariantHighest
 }

WooCommerce/Classes/POS/Presentation/Item Selector/SimpleProductCardView.swift

@@ -25,12 +25,12 @@ struct SimpleProductCardView: View {
             VStack(alignment: .leading, spacing: Constants.textSpacing) {
                 Text(product.name)
                     .lineLimit(2)
-                    .foregroundStyle(Color.posPrimaryText)
+                    .foregroundStyle(Constants.titleColor)
                     .multilineTextAlignment(.leading)
                     .font(Constants.itemTitleFont)
 
                 Text(product.formattedPrice)
-                    .foregroundStyle(Color.posSecondaryText)
+                    .foregroundStyle(Constants.detailColor)
                     .font(Constants.itemDetailFont)
             }
             .padding(.horizontal, Constants.horizontalTextPadding * (1 / scale))

WooCommerce/Classes/POS/Presentation/Item Selector/VariationCardView.swift

@@ -24,12 +24,12 @@ struct VariationCardView: View {
             VStack(alignment: .leading, spacing: Constants.textSpacing) {
                 Text(variation.name)
                     .lineLimit(2)
-                    .foregroundStyle(Color.posPrimaryText)
+                    .foregroundStyle(Constants.titleColor)
                     .multilineTextAlignment(.leading)
                     .font(Constants.itemTitleFont)
 
                 Text(variation.formattedPrice)
-                    .foregroundStyle(Color.posSecondaryText)
+                    .foregroundStyle(Constants.detailColor)
                     .font(Constants.itemDetailFont)
             }
             .padding(.horizontal, Constants.horizontalTextPadding * (1 / scale))

WooCommerce/Classes/POS/Presentation/ItemRowView.swift

@@ -5,7 +5,6 @@ struct ItemRowView: View {
     private let onItemRemoveTapped: (() -> Void)?
 
     @ScaledMetric private var scale: CGFloat = 1.0
-    @Environment(\.colorScheme) var colorScheme
     @Binding private var showProductImage: Bool
 
     private var dimension: CGFloat {
@@ -24,15 +23,15 @@ struct ItemRowView: View {
 
             VStack(alignment: .leading, spacing: Constants.itemTitleAndPriceSpacing * (1 / scale)) {
                 Text(cartItem.title)
-                    .foregroundColor(Color.posPrimaryText)
+                    .foregroundColor(PointOfSaleItemListCardConstants.titleColor)
                     .font(Constants.itemTitleFont)
                 if let subtitle = cartItem.subtitle {
                     Text(subtitle)
-                        .foregroundColor(Color.posSecondaryText)
+                        .foregroundColor(PointOfSaleItemListCardConstants.detailColor)
                         .font(Constants.itemSubtitleFont)
                 }
                 Text(cartItem.item.formattedPrice)
-                    .foregroundColor(Color.posSecondaryText)
+                    .foregroundColor(PointOfSaleItemListCardConstants.detailColor)
                     .font(Constants.itemPriceFont)
             }
             .frame(maxWidth: .infinity, alignment: .leading)