Skip to content

Commit f8d1b33

Browse files
committed
Small pull-to-refresh fixes.
1 parent 9fc4c8b commit f8d1b33

File tree

1 file changed

+11
-2
lines changed

1 file changed

+11
-2
lines changed

WooCommerce/Classes/ViewRelated/Orders/OrdersViewController.swift

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
import UIKit
22
import Gridicons
33
import Yosemite
4+
import CocoaLumberjack
5+
46

57
class OrdersViewController: UIViewController {
68

@@ -39,7 +41,9 @@ class OrdersViewController: UIViewController {
3941

4042
override func viewDidAppear(_ animated: Bool) {
4143
super.viewDidAppear(animated)
42-
syncOrders()
44+
if orders.isEmpty {
45+
syncOrders()
46+
}
4347
}
4448

4549
// MARK: - User Interface Initialization
@@ -134,7 +138,9 @@ private extension OrdersViewController {
134138
let action = OrderAction.retrieveOrders(siteID: 131820877) { [weak self] (orders, error) in
135139
self?.refreshControl.endRefreshing()
136140
guard error == nil else {
137-
print(error.debugDescription)
141+
if let error = error {
142+
DDLogError("⛔️ Error synchronizing orders: \(error)")
143+
}
138144
return
139145
}
140146
guard let orders = orders else {
@@ -144,6 +150,9 @@ private extension OrdersViewController {
144150
self?.tableView.reloadData()
145151
}
146152

153+
if refreshControl.isRefreshing {
154+
refreshControl.endRefreshing()
155+
}
147156
refreshControl.beginRefreshing()
148157
StoresManager.shared.dispatch(action)
149158
}

0 commit comments

Comments
 (0)