Skip to content

Commit f91615d

Browse files
committed
Handle background image upload notice to separate method in product split view coordinator
1 parent 700d88f commit f91615d

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

WooCommerce/Classes/ViewRelated/Products/ProductsSplitViewCoordinator.swift

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -231,12 +231,7 @@ extension ProductsSplitViewCoordinator: UINavigationControllerDelegate {
231231
func navigationController(_ navigationController: UINavigationController, didShow viewController: UIViewController, animated: Bool) {
232232
if didNavigateFromTheLastSecondaryViewControllerToProductListInCollapsedMode(navigationController, didShow: viewController) {
233233
if let contentType = contentTypes.last, case let .productForm(product) = contentType, let product {
234-
let uploader = ServiceLocator.productImageUploader
235-
let key = ProductImageUploaderKey(siteID: product.siteID,
236-
productOrVariationID: .product(id: product.productID),
237-
isLocalID: false)
238-
uploader.startEmittingErrors(key: key)
239-
uploader.sendBackgroundUploadNoticeIfNeeded(key: key, using: ServiceLocator.noticePresenter)
234+
didDismissProductForm(product: product)
240235
}
241236
contentTypes = []
242237
secondaryNavigationController.viewControllers = []
@@ -277,6 +272,15 @@ private extension ProductsSplitViewCoordinator {
277272
return splitViewController.isCollapsed && navigationController == primaryNavigationController
278273
&& contentTypes.isNotEmpty && isNavigatingToProductList
279274
}
275+
276+
func didDismissProductForm(product: Product) {
277+
let uploader = ServiceLocator.productImageUploader
278+
let key = ProductImageUploaderKey(siteID: product.siteID,
279+
productOrVariationID: .product(id: product.productID),
280+
isLocalID: false)
281+
uploader.startEmittingErrors(key: key)
282+
uploader.sendBackgroundUploadNoticeIfNeeded(key: key, using: ServiceLocator.noticePresenter)
283+
}
280284
}
281285

282286
private extension ProductsSplitViewCoordinator {

0 commit comments

Comments
 (0)