[Mobile Payments] Show gateway specific documentation when learn more tapped (#15035)

Author: joshheald

RELEASE-NOTES.txt

@@ -2,6 +2,7 @@
 *** Use [*****] to indicate smoke tests of all critical flows should be run on the final IPA before release (e.g. major library or OS update).
 21.7
 -----
+- [*] Payments: Update learn more links to open Stripe-specific docs when using that gateway [https://github.com/woocommerce/woocommerce-ios/pull/15035]
 - [x] Now, usernames and emails in text fields across multiple login views are no longer capitalized. [https://github.com/woocommerce/woocommerce-ios/pull/15002]
 
 21.6

WooCommerce/Classes/ViewRelated/Dashboard/Settings/CardReadersV2/CardPresentPaymentPlugin+SetUpTapToPay.swift

@@ -0,0 +1,22 @@
+import Foundation
+import Yosemite
+
+extension CardPresentPaymentsPlugin {
+    var manageCardReaderLearnMoreURL: URL {
+        switch self {
+        case .wcPay:
+            return WooConstants.URLs.inPersonPaymentsLearnMoreWCPay.asURL()
+        case .stripe:
+            return WooConstants.URLs.inPersonPaymentsLearnMoreStripe.asURL()
+        }
+    }
+
+    var setUpTapToPayLearnMoreURL: URL {
+        switch self {
+        case .wcPay:
+            return WooConstants.URLs.inPersonPaymentsLearnMoreWCPayTapToPay.asURL()
+        case .stripe:
+            return WooConstants.URLs.inPersonPaymentsLearnMoreStripe.asURL()
+        }
+    }
+}

WooCommerce/Classes/ViewRelated/Dashboard/Settings/CardReadersV2/CardReaderSettingsSearchingViewController.swift

@@ -1,4 +1,5 @@
 import SwiftUI
+import Yosemite
 
 /// This view controller is used when no reader is connected. It assists
 /// the merchant in connecting to a reader.
@@ -37,7 +38,7 @@ final class CardReaderSettingsSearchingViewController: UIHostingController<CardR
         }
         self.viewModel = viewModel
 
-        super.init(rootView: CardReaderSettingsSearchingView())
+        super.init(rootView: CardReaderSettingsSearchingView(learnMoreURL: viewModel.learnMoreURL))
         configureView()
     }
 
@@ -49,7 +50,6 @@ final class CardReaderSettingsSearchingViewController: UIHostingController<CardR
             guard let self = self else { return }
             WebviewHelper.launch(url, with: self)
         }
-        rootView.learnMoreUrl = viewModel.learnMoreURL
     }
 
     required init?(coder: NSCoder) {
@@ -115,7 +115,7 @@ private extension CardReaderSettingsSearchingViewController {
 struct CardReaderSettingsSearchingView: View {
     var connectClickAction: (() -> Void)? = nil
     var showURL: ((URL) -> Void)? = nil
-    var learnMoreUrl: URL? = nil
+    var learnMoreURL: URL
 
     @Environment(\.verticalSizeClass) var verticalSizeClass
     @Environment(\.sizeCategory) private var sizeCategory
@@ -154,17 +154,11 @@ struct CardReaderSettingsSearchingView: View {
                 .padding(.bottom, 8)
 
             InPersonPaymentsLearnMore(viewModel: LearnMoreViewModel(
+                url: learnMoreURL,
                 tappedAnalyticEvent: .InPersonPayments.learnMoreTapped(source: .manageCardReader)))
             .padding(.vertical, 8)
             .customOpenURL(action: { url in
-                switch url {
-                case LearnMoreViewModel.learnMoreURL:
-                    if let url = learnMoreUrl {
-                        showURL?(url)
-                    }
-                default:
-                    showURL?(url)
-                }
+                showURL?(url)
             })
         }
         .frame(
@@ -221,6 +215,8 @@ private enum Localization {
 
 struct CardReaderSettingsSearchingView_Previews: PreviewProvider {
     static var previews: some View {
-        CardReaderSettingsSearchingView(connectClickAction: {})
+        CardReaderSettingsSearchingView(
+            connectClickAction: {},
+            learnMoreURL: WooConstants.URLs.inPersonPaymentsLearnMoreWCPay.asURL())
     }
 }

WooCommerce/Classes/ViewRelated/Dashboard/Settings/CardReadersV2/CardReaderSettingsSearchingViewModel.swift

@@ -6,7 +6,7 @@ final class CardReaderSettingsSearchingViewModel: PaymentSettingsFlowPresentedVi
     private(set) var shouldShow: CardReaderSettingsTriState = .isUnknown
     var didChangeShouldShow: ((CardReaderSettingsTriState) -> Void)?
     var didUpdate: (() -> Void)?
-    var learnMoreURL: URL? = nil
+    var learnMoreURL: URL
 
     private(set) var noConnectedReader: CardReaderSettingsTriState = .isUnknown {
         didSet {
@@ -43,6 +43,7 @@ final class CardReaderSettingsSearchingViewModel: PaymentSettingsFlowPresentedVi
         self.knownReaderProvider = knownReaderProvider
         self.configuration = configuration
         self.cardReaderConnectionAnalyticsTracker = cardReaderConnectionAnalyticsTracker
+        self.learnMoreURL = CardPresentPaymentsPlugin.wcPay.setUpTapToPayLearnMoreURL
 
         beginKnownReaderObservation()
         beginConnectedReaderObservation()
@@ -108,12 +109,7 @@ final class CardReaderSettingsSearchingViewModel: PaymentSettingsFlowPresentedVi
     private func updateLearnMoreUrl(stores: StoresManager) {
         let loadLearnMoreUrlAction = CardPresentPaymentAction
             .loadActivePaymentGatewayExtension() { [weak self] result in
-                switch result {
-                case .wcpay:
-                    self?.learnMoreURL = WooConstants.URLs.inPersonPaymentsLearnMoreWCPay.asURL()
-                case .stripe:
-                    self?.learnMoreURL = WooConstants.URLs.inPersonPaymentsLearnMoreStripe.asURL()
-                }
+                result.manageCardReaderLearnMoreURL
             }
         stores.dispatch(loadLearnMoreUrlAction)
     }

WooCommerce/Classes/ViewRelated/Dashboard/Settings/CardReadersV2/SetUpTapToPayCompleteViewController.swift

@@ -83,6 +83,7 @@ struct SetUpTapToPayCompleteView: View {
 
             InPersonPaymentsLearnMore(
                 viewModel: LearnMoreViewModel(
+                    url: viewModel.learnMoreURL,
                     formatText: Localization.learnMore,
                     tappedAnalyticEvent: .InPersonPayments.learnMoreTapped(source: .tapToPaySummary)))
             .padding(.vertical, Constants.learnMorePadding)

WooCommerce/Classes/ViewRelated/Dashboard/Settings/CardReadersV2/SetUpTapToPayCompleteViewModel.swift

@@ -18,12 +18,15 @@ final class SetUpTapToPayCompleteViewModel: PaymentSettingsFlowPresentedViewMode
     private let analytics: Analytics = ServiceLocator.analytics
 
     private var subscriptions = Set<AnyCancellable>()
+    private(set) var learnMoreURL: URL
 
     init(didChangeShouldShow: ((CardReaderSettingsTriState) -> Void)?,
          connectionAnalyticsTracker: CardReaderConnectionAnalyticsTracker,
          stores: StoresManager = ServiceLocator.stores) {
         self.didChangeShouldShow = didChangeShouldShow
         self.connectionAnalyticsTracker = connectionAnalyticsTracker
+        /// The `learnMoreURL` will be updated when a reader connects
+        self.learnMoreURL = CardPresentPaymentsPlugin.wcPay.setUpTapToPayLearnMoreURL
         self.stores = stores
 
         beginConnectedReaderObservation()
@@ -34,11 +37,10 @@ final class SetUpTapToPayCompleteViewModel: PaymentSettingsFlowPresentedViewMode
     private func beginConnectedReaderObservation() {
         // This completion should be called repeatedly as the list of connected readers changes
         let connectedAction = CardPresentPaymentAction.observeConnectedReaders() { [weak self] readers in
-            guard let self = self else {
-                return
-            }
-            self.connectedReader = readers.isNotEmpty ? .isTrue : .isFalse
-            self.reevaluateShouldShow()
+            guard let self else { return }
+            connectedReader = readers.isNotEmpty ? .isTrue : .isFalse
+            reevaluateShouldShow()
+            updateLearnMoreURL()
         }
         stores.dispatch(connectedAction)
     }
@@ -63,6 +65,13 @@ final class SetUpTapToPayCompleteViewModel: PaymentSettingsFlowPresentedViewMode
         }
     }
 
+    private func updateLearnMoreURL() {
+        let action = CardPresentPaymentAction.loadActivePaymentGatewayExtension { [weak self] paymentGateway in
+            self?.learnMoreURL = paymentGateway.setUpTapToPayLearnMoreURL
+        }
+        stores.dispatch(action)
+    }
+
     func doneTapped() {
         analytics.track(.tapToPaySetupSuccessDoneTapped)
         doneWasTapped = true

WooCommerce/Classes/ViewRelated/Dashboard/Settings/CardReadersV2/SetUpTapToPayInformationViewController.swift

@@ -53,7 +53,6 @@ final class SetUpTapToPayInformationViewController: UIHostingController<SetUpTap
             guard let self = self else { return }
             WebviewHelper.launch(url, with: self)
         }
-        rootView.learnMoreUrl = viewModel.learnMoreURL
     }
 
     required init?(coder: NSCoder) {
@@ -69,7 +68,6 @@ final class SetUpTapToPayInformationViewController: UIHostingController<SetUpTap
 struct SetUpTapToPayInformationView: View {
     @ObservedObject var viewModel: SetUpTapToPayInformationViewModel
     var showURL: ((URL) -> Void)? = nil
-    var learnMoreUrl: URL? = nil
     @State var showingAboutTapToPay: Bool = false
 
     @Environment(\.verticalSizeClass) var verticalSizeClass
@@ -124,6 +122,7 @@ struct SetUpTapToPayInformationView: View {
 
                 InPersonPaymentsLearnMore(
                     viewModel: LearnMoreViewModel(
+                        url: viewModel.learnMoreURL,
                         formatText: Localization.learnMore,
                         tappedAnalyticEvent: .InPersonPayments.learnMoreTapped(source: .tapToPaySummary)))
                 .padding(.vertical, Constants.learnMorePadding)

WooCommerce/Classes/ViewRelated/Dashboard/Settings/CardReadersV2/SetUpTapToPayInformationViewModel.swift

@@ -50,7 +50,8 @@ final class SetUpTapToPayInformationViewModel: PaymentSettingsFlowPresentedViewM
         self.connectionAnalyticsTracker = connectionAnalyticsTracker
         self.connectivityObserver = connectivityObserver
         self.onboardingStatePublisher = onboardingStatePublisher
-        self.learnMoreURL = Self.learnMoreURL(for: .wcPay) // this will be updated when the onboarding state is known
+        /// The `learnMoreURL` will be updated when the onboarding state is known
+        self.learnMoreURL = CardPresentPaymentsPlugin.wcPay.setUpTapToPayLearnMoreURL
         self.tapToPayAwarenessMomentDeterminer = tapToPayAwarenessMomentDeterminer
 
         beginOnboardingStateObservation()
@@ -68,7 +69,7 @@ final class SetUpTapToPayInformationViewModel: PaymentSettingsFlowPresentedViewM
             guard case .completed(let plugin) = onboardingState else {
                 return
             }
-            self?.learnMoreURL = Self.learnMoreURL(for: plugin.preferred)
+            self?.learnMoreURL = plugin.preferred.setUpTapToPayLearnMoreURL
         }.store(in: &subscriptions)
     }
 
@@ -151,17 +152,6 @@ final class SetUpTapToPayInformationViewModel: PaymentSettingsFlowPresentedViewM
             didChangeShouldShow?(shouldShow)
         }
     }
-
-    /// Choose learn more url based on the active Payment Gateway extension
-    ///
-    private static func learnMoreURL(for paymentGateway: CardPresentPaymentsPlugin) -> URL {
-        switch paymentGateway {
-        case .wcPay:
-            return WooConstants.URLs.inPersonPaymentsLearnMoreWCPayTapToPay.asURL()
-        case .stripe:
-            return WooConstants.URLs.inPersonPaymentsLearnMoreStripe.asURL()
-        }
-    }
 }
 
 private extension [CardReader] {

WooCommerce/Classes/ViewRelated/Dashboard/Settings/In-Person Payments/CardPresentPaymentsOnboardingViewController.swift

@@ -97,10 +97,6 @@ struct CardPresentPaymentsOnboardingView: View {
             switch url {
             case InPersonPaymentsSupportLink.supportURL:
                 viewModel.showSupport?()
-            case LearnMoreViewModel.learnMoreURL:
-                if let url = viewModel.learnMoreURL {
-                    viewModel.showURL?(url)
-                }
             default:
                 viewModel.showURL?(url)
             }

WooCommerce/Classes/ViewRelated/Dashboard/Settings/In-Person Payments/InPersonPaymentsLearnMore.swift

@@ -6,7 +6,7 @@ struct InPersonPaymentsLearnMore: View {
     @ObservedObject private var viewModel: LearnMoreViewModel
     private let showInfoIcon: Bool
 
-    init(viewModel: LearnMoreViewModel = LearnMoreViewModel(),
+    init(viewModel: LearnMoreViewModel,
          showInfoIcon: Bool = true) {
         self.viewModel = viewModel
         self.showInfoIcon = showInfoIcon
@@ -40,7 +40,9 @@ struct InPersonPaymentsLearnMore: View {
 
 struct InPersonPaymentsLearnMore_Previews: PreviewProvider {
     static var previews: some View {
-        InPersonPaymentsLearnMore()
+        InPersonPaymentsLearnMore(viewModel: .inPersonPayments(source: .paymentMethods,
+                                                               paymentGateway: .wcPay),
+                                  showInfoIcon: true)
             .padding()
     }
 }