Set and unset notice label in view model

Author: rachelmcr

WooCommerce/Classes/ViewRelated/Orders/Order Details/Shipping Labels/WooShipping Create Shipping Labels/WooShippingCreateLabelsView.swift

@@ -148,12 +148,10 @@ private extension WooShippingCreateLabelsView {
             Text(Localization.BottomSheet.shipmentDetails)
                 .foregroundStyle(Color(.primary))
                 .bold()
-            if viewModel.showAddressVerificationNotice {
-                addressVerificationNotice
-                    .onTapGesture {
-                        // TODO: Start address editing/verification flow if needed (if destination address is unverified).
-                    }
-            }
+            addressVerificationNotice(with: viewModel.destinationAddressStatusNoticeLabel)
+                .onTapGesture {
+                    // TODO: Start address editing/verification flow if needed (if destination address is unverified).
+                }
         }
     }
 
@@ -314,26 +312,29 @@ private extension WooShippingCreateLabelsView {
     }
 
     /// View showing a notice about the destination address verification status.
-    var addressVerificationNotice: some View {
-        HStack(spacing: 8) {
-            Image(systemName: isDestinationAddressVerified ? "checkmark.circle" : "exclamationmark.circle")
-            Text(Localization.AddressVerification.noticeLabel(for: viewModel.destinationAddressStatus))
-                .frame(maxWidth: .infinity, alignment: .leading)
-            Button {
-                withAnimation {
-                    viewModel.showAddressVerificationNotice = false
+    @ViewBuilder
+    func addressVerificationNotice(with label: String?) -> some View {
+        if let label = viewModel.destinationAddressStatusNoticeLabel {
+            HStack(spacing: 8) {
+                Image(systemName: isDestinationAddressVerified ? "checkmark.circle" : "exclamationmark.circle")
+                Text(label)
+                    .frame(maxWidth: .infinity, alignment: .leading)
+                Button {
+                    withAnimation {
+                        viewModel.destinationAddressStatusNoticeLabel = nil
+                    }
+                } label: {
+                    Image(systemName: "xmark")
+                        .renderedIf(!isDestinationAddressVerified)
                 }
-            } label: {
-                Image(systemName: "xmark")
-                    .renderedIf(!isDestinationAddressVerified)
             }
+            .font(.subheadline)
+            .foregroundStyle(isDestinationAddressVerified ? Layout.green : Layout.red)
+            .padding(.horizontal, 16)
+            .padding(.vertical, 12)
+            .background(RoundedRectangle(cornerRadius: Layout.cornerRadius)
+                .fill(Color(uiColor: isDestinationAddressVerified ? .withColorStudio(.green, shade: .shade0) : .withColorStudio(.red, shade: .shade0))))
         }
-        .font(.subheadline)
-        .foregroundStyle(isDestinationAddressVerified ? Layout.green : Layout.red)
-        .padding(.horizontal, 16)
-        .padding(.vertical, 12)
-        .background(RoundedRectangle(cornerRadius: Layout.cornerRadius)
-            .fill(Color(uiColor: isDestinationAddressVerified ? .withColorStudio(.green, shade: .shade0) : .withColorStudio(.red, shade: .shade0))))
     }
 }
 
@@ -449,25 +450,6 @@ private extension WooShippingCreateLabelsView {
             static let missing = NSLocalizedString("wooShipping.createLabels.addressVerification.missing",
                                                    value: "Missing address",
                                                    comment: "Label when an address is missing on the shipping label creation screen")
-            static func noticeLabel(for status: WooShippingCreateLabelsViewModel.DestinationAddressStatus) -> String {
-                switch status {
-                case .verified:
-                    return destinationVerified
-                case .unverified:
-                    return destinationUnverified
-                case .missing:
-                    return destinationMissing
-                }
-            }
-            static let destinationVerified = NSLocalizedString("wooShipping.createLabels.addressVerification.destinationVerified",
-                                                          value: "Verified destination address",
-                                                          comment: "Notice when a destination address is verified on the shipping label creation screen")
-            static let destinationUnverified = NSLocalizedString("wooShipping.createLabels.addressVerification.destinationUnverified",
-                                                            value: "Destination address unverified",
-                                                            comment: "Notice when a destination address is unverified on the shipping label creation screen")
-            static let destinationMissing = NSLocalizedString("wooShipping.createLabels.addressVerification.destinationMissing",
-                                                            value: "Destination address missing",
-                                                            comment: "Notice when a destination address is missing on the shipping label creation screen")
         }
     }
 }

WooCommerce/Classes/ViewRelated/Orders/Order Details/Shipping Labels/WooShipping Create Shipping Labels/WooShippingCreateLabelsViewModel.swift

@@ -76,10 +76,8 @@ final class WooShippingCreateLabelsViewModel: ObservableObject {
     /// The current destination address status.
     @Published private(set) var destinationAddressStatus: DestinationAddressStatus = .unverified
 
-    // TODO: Set to false if the destination address is already verified.
-    // TODO: Set to true for a couple seconds after the destination address is verified.
-    /// Whether the destination address verification notice is displayed.
-    @Published var showAddressVerificationNotice = true
+    /// This property can be set to display a notice with the provided label about the destination address status.
+    @Published var destinationAddressStatusNoticeLabel: String?
 
     /// Shipping lines for the order, with formatted amount.
     let shippingLines: [WooShipping_ShippingLineViewModel]
@@ -191,6 +189,7 @@ final class WooShippingCreateLabelsViewModel: ObservableObject {
         destinationAddressStatus = destinationAddressLines == nil ? .missing : .unverified
 
         observeSelectedOriginAddress()
+        observeDestinationAddressStatus()
         observeSelectedPackage()
         observeForLabelRates()
         loadStoreOptions()
@@ -341,6 +340,30 @@ private extension WooShippingCreateLabelsViewModel {
             .store(in: &subscriptions)
     }
 
+    /// Observes the destination address status and updates the notice label.
+    func observeDestinationAddressStatus() {
+        /// Set the notice when the destination address status changes.
+        $destinationAddressStatus
+            .map { status in
+                switch status {
+                case .verified:
+                    return Localization.DestinationAddressStatus.verified
+                case .unverified:
+                    return Localization.DestinationAddressStatus.unverified
+                case .missing:
+                    return Localization.DestinationAddressStatus.missing
+                }
+            }
+            .assign(to: &$destinationAddressStatusNoticeLabel)
+
+        /// Clear the notice after a delay when the address is verified.
+        $destinationAddressStatusNoticeLabel
+            .filter { $0 == Localization.DestinationAddressStatus.verified }
+            .delay(for: .seconds(2), scheduler: RunLoop.current)
+            .map { _ in nil }
+            .assign(to: &$destinationAddressStatusNoticeLabel)
+    }
+
     /// Observes the selected package and shipment weight and requests the available shipping rates.
     func observeForLabelRates() {
         $shipmentWeight
@@ -461,6 +484,18 @@ private extension WooShippingCreateLabelsViewModel {
                                                               value: "Adult Signature Required",
                                                               comment: "Label for row showing the additional cost to require an adult signature " +
                                                               "on the shipping label creation screen")
+
+        enum DestinationAddressStatus {
+            static let verified = NSLocalizedString("wooShipping.createLabels.addressVerification.destinationVerified",
+                                                               value: "Verified destination address",
+                                                               comment: "Notice when a destination address is verified on the shipping label creation screen")
+            static let unverified = NSLocalizedString("wooShipping.createLabels.addressVerification.destinationUnverified",
+                                                                 value: "Destination address unverified",
+                                                                 comment: "Notice when a destination address is unverified on the shipping label creation screen")
+            static let missing = NSLocalizedString("wooShipping.createLabels.addressVerification.destinationMissing",
+                                                              value: "Destination address missing",
+                                                              comment: "Notice when a destination address is missing on the shipping label creation screen")
+        }
     }
 
     enum Constants {