Show errors when refreshing catalog from settings

Author: joshheald

Modules/Sources/PointOfSale/Models/PointOfSaleErrorState.swift

@@ -1,9 +1,10 @@
 import Foundation
 import enum Alamofire.AFError
 
-struct PointOfSaleErrorState: Equatable {
+struct PointOfSaleErrorState: Equatable, Identifiable {
     enum ErrorType: Equatable {
         case initialCatalogSyncError
+        case refreshCatalogSyncError
         case productsLoadError
         case variationsLoadError
         case productsNextPageError
@@ -16,6 +17,7 @@ struct PointOfSaleErrorState: Equatable {
         case ordersNextPageError
     }
 
+    let id = UUID()
     let errorType: ErrorType
     let title: String
     let subtitle: String
@@ -117,6 +119,14 @@ struct PointOfSaleErrorState: Equatable {
             buttonText: Constants.retryButtonTitle)
     }
 
+    static func errorOnRefreshingCatalog(error: Error? = nil) -> Self {
+        PointOfSaleErrorState(
+            errorType: .refreshCatalogSyncError,
+            title: Constants.failedToRefreshCatalogTitle,
+            subtitle: subtitle(for: error),
+            buttonText: Constants.retryButtonTitle)
+    }
+
     private static func subtitle(for error: Error?) -> String {
         if let error, error.isConnectivityError {
             return Constants.connectivityErrorSubtitle
@@ -141,6 +151,11 @@ struct PointOfSaleErrorState: Equatable {
             value: "Unable to sync catalog",
             comment: "Title appearing on the item list screen when there's an error syncing the catalog for the first time."
         )
+        static let failedToRefreshCatalogTitle = NSLocalizedString(
+            "pos.catalog.refreshFailedTitle",
+            value: "Unable to refresh catalog",
+            comment: "Title appearing in a modal when there's an error refreshing the catalog."
+        )
         static let loadingCouponsErrorTitle = NSLocalizedString(
             "pos.itemList.loadingCouponsErrorTitle.2",
             value: "Unable to load coupons",

Modules/Sources/PointOfSale/Presentation/Settings/POSSettingsLocalCatalogDetailView.swift

@@ -8,6 +8,7 @@ struct POSSettingsLocalCatalogDetailView: View {
     }
 
     var body: some View {
+        @Bindable var viewModel = viewModel
         NavigationStack {
             VStack(spacing: POSSpacing.none) {
                 POSPageHeaderView(title: Localization.localCatalogTitle)
@@ -28,6 +29,13 @@ struct POSSettingsLocalCatalogDetailView: View {
         .task {
             await viewModel.loadCatalogData()
         }
+        .posModal(item: $viewModel.catalogRefreshError) { errorState in
+            POSListErrorView(error: errorState, onAction: {
+                Task {
+                    await viewModel.refreshCatalog()
+                }
+            })
+        }
     }
 }
 

Modules/Sources/PointOfSale/Presentation/Settings/POSSettingsLocalCatalogViewModel.swift

@@ -12,6 +12,8 @@ final class POSSettingsLocalCatalogViewModel {
     private(set) var isLoading: Bool = false
     private(set) var isRefreshingCatalog: Bool = false
 
+    var catalogRefreshError: PointOfSaleErrorState? = nil
+
     private let siteID: Int64
     private let catalogSettingsService: POSCatalogSettingsServiceProtocol
     private let catalogSyncCoordinator: POSCatalogSyncCoordinatorProtocol
@@ -78,15 +80,16 @@ final class POSSettingsLocalCatalogViewModel {
     @MainActor
     func refreshCatalog() async {
         isRefreshingCatalog = true
+        catalogRefreshError = nil
 
         do {
             try await catalogSyncCoordinator.performFullSync(for: siteID, regenerateCatalog: true)
-            // Sync completed synchronously - update UI
             isRefreshingCatalog = false
             await loadCatalogData()
         } catch {
             DDLogError("⛔️ POSSettingsLocalCatalog: Failed to refresh catalog: \(error)")
             isRefreshingCatalog = false
+            catalogRefreshError = PointOfSaleErrorState.errorOnRefreshingCatalog(error: error)
         }
     }
 

Modules/Tests/PointOfSaleTests/Presentation/Settings/POSSettingsLocalCatalogViewModelTests.swift

@@ -32,6 +32,7 @@ struct POSSettingsLocalCatalogViewModelTests {
         #expect(sut.lastIncrementalSyncDate == "")
         #expect(sut.isLoading == false)
         #expect(sut.isRefreshingCatalog == false)
+        #expect(sut.catalogRefreshError == nil)
     }
 
     // MARK: - `loadCatalogData` Tests
@@ -175,6 +176,24 @@ struct POSSettingsLocalCatalogViewModelTests {
         #expect(sut.isRefreshingCatalog == false)
     }
 
+    @Test func refreshCatalog_sets_refresh_error_state_when_sync_fails() async throws {
+        // Given
+        catalogSettingsService.catalogInfoResult = .success(POSCatalogInfo(
+            productCount: 50,
+            variationCount: 25,
+            lastFullSyncDate: nil,
+            lastIncrementalSyncDate: nil
+        ))
+        catalogSyncCoordinator.performFullSyncResult = .failure(MockError.syncError)
+
+        // When
+        await sut.refreshCatalog()
+
+        // Then
+        let catalogRefreshError = try #require(sut.catalogRefreshError)
+        #expect(catalogRefreshError.errorType == .refreshCatalogSyncError)
+    }
+
     // MARK: - Test Concurrent Operations
 
     @Test func concurrent_loadCatalogData_and_refreshCatalog_operations_work_correctly() async throws {