Filter out non-default discount types when mapping coupons

Author: itsmeichigo

Networking/Networking/Mapper/CouponListMapper.swift

@@ -12,7 +12,9 @@ struct CouponListMapper: Mapper {
     ///
     func map(response: Data) throws -> [Coupon] {
         let coupons = try Coupon.decoder.decode(CouponListEnvelope.self, from: response).coupons
-        return coupons.map { $0.copy(siteID: siteID) }
+        return coupons
+            .map { $0.copy(siteID: siteID) }
+            .filter { $0.mappedDiscountType != nil }
     }
 }
 

Networking/Networking/Model/Coupon.swift

@@ -26,7 +26,22 @@ public struct Coupon {
     public let dateModified: Date
 
     /// Determines the type of discount that will be applied. Options: `.percent` `.fixedCart` and `.fixedProduct`
-    public let discountType: DiscountType
+    public var discountType: DiscountType {
+        if let type = mappedDiscountType {
+            return type
+        } else {
+            // Returns default value for fallback case to avoid working with optionals.
+            // Since `CouponListMapper` filters out nil `mappedDiscountType`,
+            // this case is unlikely to happen.
+            return .fixedCart
+        }
+    }
+
+    /// Discount type if matched with any of the ones supported by Core.
+    /// Returns nil if other types are found.
+    /// Used to filter only coupons with default types, so internal to this module only.
+    ///
+    internal let mappedDiscountType: DiscountType?
 
     public let description: String
 
@@ -78,6 +93,9 @@ public struct Coupon {
     /// Email addresses of customers who have used this coupon
     public let usedBy: [String]
 
+    /// Discount types supported by Core.
+    /// There are other types supported by other plugins, but those are not supported for now.
+    ///
     public enum DiscountType: String {
         case percent = "percent"
         case fixedCart = "fixed_cart"
@@ -114,7 +132,7 @@ public struct Coupon {
         self.amount = amount
         self.dateCreated = dateCreated
         self.dateModified = dateModified
-        self.discountType = discountType
+        self.mappedDiscountType = discountType
         self.description = description
         self.dateExpires = dateExpires
         self.usageCount = usageCount
@@ -148,7 +166,7 @@ extension Coupon: Codable {
         case amount
         case dateCreated = "dateCreatedGmt"
         case dateModified = "dateModifiedGmt"
-        case discountType
+        case mappedDiscountType
         case description
         case dateExpires = "dateExpiresGmt"
         case usageCount