Marked code need to change presenting product detail

adborbas · adborbas · commit fc0fa076821f · 2025-10-22T12:37:27.000+02:00
diff --git a/WooCommerce/Classes/ViewModels/Order Details/OrderDetailsViewModel.swift b/WooCommerce/Classes/ViewModels/Order Details/OrderDetailsViewModel.swift
@@ -510,6 +510,7 @@ extension OrderDetailsViewModel {
             viewController.present(navController, animated: true, completion: nil)
         case .aggregateOrderItem:
             let item = dataSource.aggregateOrderItems[indexPath.row]
+            // TODO: Replace with ProductDetailRouter
             let loaderViewController = ProductLoaderViewController(model: .init(aggregateOrderItem: item),
                                                                    siteID: order.siteID,
                                                                    forceReadOnly: false)
diff --git a/WooCommerce/Classes/ViewModels/Order Details/Refund Details/RefundDetailsViewModel.swift b/WooCommerce/Classes/ViewModels/Order Details/Refund Details/RefundDetailsViewModel.swift
@@ -128,6 +128,7 @@ extension RefundDetailsViewModel {
 
         case .orderItem:
             let item = refund.items[indexPath.row]
+            // TODO: Replace with ProductDetailRouter, native
             let loaderViewController = ProductLoaderViewController(model: .init(orderItemRefund: item),
                                                                    siteID: refund.siteID,
                                                                    forceReadOnly: true)
diff --git a/WooCommerce/Classes/ViewRelated/Dashboard/ProductStock/ProductStockDashboardCard.swift b/WooCommerce/Classes/ViewRelated/Dashboard/ProductStock/ProductStockDashboardCard.swift
@@ -189,6 +189,7 @@ private extension ProductStockDashboardCard {
                 .product(productID: item.productID)
             }
         }()
+        // TODO: Replace with ProductDetailRouter
         let loaderViewController = ProductLoaderViewController(model: model,
                                                                siteID: viewModel.siteID,
                                                                forceReadOnly: false)
diff --git a/WooCommerce/Classes/ViewRelated/Dashboard/TopPerformers/TopPerformerDataViewController.swift b/WooCommerce/Classes/ViewRelated/Dashboard/TopPerformers/TopPerformerDataViewController.swift
@@ -176,6 +176,7 @@ private extension TopPerformerDataViewController {
     /// Presents the product details for a given TopEarnerStatsItem.
     ///
     func presentProductDetails(statsItem: TopEarnerStatsItem) {
+        // TODO: Replace with ProductDetailRouter
         let loaderViewController = ProductLoaderViewController(model: .init(topEarnerStatsItem: statsItem),
                                                                siteID: siteID,
                                                                forceReadOnly: false)
diff --git a/WooCommerce/Classes/ViewRelated/Dashboard/TopPerformers/TopPerformersDashboardView.swift b/WooCommerce/Classes/ViewRelated/Dashboard/TopPerformers/TopPerformersDashboardView.swift
@@ -181,6 +181,7 @@ private extension TopPerformersDashboardView {
     }
 
     func productDetailView(for item: TopEarnerStatsItem) -> UIViewController {
+        // TODO: Replace with ProductDetailRouter
         let loaderViewController = ProductLoaderViewController(model: .init(topEarnerStatsItem: item),
                                                                siteID: viewModel.siteID,
                                                                forceReadOnly: false)
diff --git a/WooCommerce/Classes/ViewRelated/MainTabBarController.swift b/WooCommerce/Classes/ViewRelated/MainTabBarController.swift
@@ -1036,6 +1036,7 @@ private extension MainTabBarController {
                 return .productVariation(productID: productID, variationID: variationID)
             }
         }()
+        // TODO: Replace with ProductDetailRouter
         let productViewController = ProductLoaderViewController(model: model,
                                                                 siteID: error.siteID,
                                                                 forceReadOnly: false)
diff --git a/WooCommerce/Classes/ViewRelated/Orders/Order Details/Product List Section/Product Details/AggregatedProductListViewController.swift b/WooCommerce/Classes/ViewRelated/Orders/Order Details/Product List Section/Product Details/AggregatedProductListViewController.swift
@@ -122,6 +122,7 @@ private extension AggregatedProductListViewController {
     /// Displays the product details screen for the provided AggregateOrderItem
     ///
     func productWasPressed(orderItem: AggregateOrderItem) {
+        // TODO: Replace with ProductDetailRouter, native
         let loaderViewController = ProductLoaderViewController(model: .init(aggregateOrderItem: orderItem),
                                                                siteID: viewModel.order.siteID,
                                                                forceReadOnly: true)
diff --git a/WooCommerce/Classes/ViewRelated/Products/Product Loader/ProductLoaderView.swift b/WooCommerce/Classes/ViewRelated/Products/Product Loader/ProductLoaderView.swift
@@ -9,6 +9,7 @@ struct ProductLoaderView: UIViewControllerRepresentable {
     let forceReadOnly: Bool
 
     func makeUIViewController(context: Context) -> UINavigationController {
+        // TODO: Replace with ProductDetailRouter
         let viewController = ProductLoaderViewController(model: model,
                                                          siteID: siteID,
                                                          forceReadOnly: forceReadOnly)
diff --git a/WooCommerce/Classes/ViewRelated/Products/Product Loader/ProductLoaderViewController.swift b/WooCommerce/Classes/ViewRelated/Products/Product Loader/ProductLoaderViewController.swift
@@ -227,6 +227,7 @@ private extension ProductLoaderViewController {
     /// Presents the ProductFormViewController, as a childViewController, for a given Product.
     ///
     func presentProductDetails(for product: Product) {
+        // TODO: Replace with ProductDetailRouter
         ProductDetailsFactory.productDetails(product: product,
                                              presentationStyle: .contained(containerViewController: { [weak self] in self }),
                                              forceReadOnly: forceReadOnly) { [weak self] viewController in
diff --git a/WooCommerce/Classes/ViewRelated/Products/ProductsSplitViewCoordinator.swift b/WooCommerce/Classes/ViewRelated/Products/ProductsSplitViewCoordinator.swift
@@ -122,6 +122,7 @@ private extension ProductsSplitViewCoordinator {
     }
 
     func showProductForm(product: Product) {
+        // TODO: Replace with ProductDetailRouter
         ProductDetailsFactory.productDetails(product: product,
                                              presentationStyle: .navigationStack,
                                              forceReadOnly: false,
diff --git a/WooCommerce/Classes/ViewRelated/Products/ProductsViewController.swift b/WooCommerce/Classes/ViewRelated/Products/ProductsViewController.swift
@@ -1214,13 +1214,15 @@ extension ProductsViewController: UITableViewDelegate {
 private extension ProductsViewController {
     func didSelectProduct(product: Product) {
         guard isSplitViewEnabled else {
+            // TODO: Replace with ProductDetailRouter
             ProductDetailsFactory.productDetails(product: product,
                                                  presentationStyle: .navigationStack,
                                                  forceReadOnly: false) { [weak self] viewController in
                 self?.navigationController?.pushViewController(viewController, animated: true)
             }
             return
         }
+        // TODO: Replace with ProductDetailRouter
         navigateToContent(.productForm(product: product))
     }
 }
diff --git a/WooCommerce/WooCommerceTests/ViewRelated/Products/ProductDetailsFactoryTests.swift b/WooCommerce/WooCommerceTests/ViewRelated/Products/ProductDetailsFactoryTests.swift
@@ -12,6 +12,7 @@ final class ProductDetailsFactoryTests: XCTestCase {
 
         let exp = expectation(description: #function)
         // Action
+        // TODO: Replace with ProductDetailRouter
         ProductDetailsFactory.productDetails(product: product,
                                              presentationStyle: .navigationStack,
                                              forceReadOnly: false) { viewController in
@@ -30,6 +31,7 @@ final class ProductDetailsFactoryTests: XCTestCase {
         let exp = expectation(description: #function)
 
         // Action
+        // TODO: Replace with ProductDetailRouter
         ProductDetailsFactory.productDetails(product: product,
                                              presentationStyle: .navigationStack,
                                              forceReadOnly: false) { viewController in
@@ -48,6 +50,7 @@ final class ProductDetailsFactoryTests: XCTestCase {
         let exp = expectation(description: #function)
 
         // Action
+        // TODO: Replace with ProductDetailRouter
         ProductDetailsFactory.productDetails(product: product,
                                              presentationStyle: .navigationStack,
                                              forceReadOnly: false) { viewController in
@@ -66,6 +69,7 @@ final class ProductDetailsFactoryTests: XCTestCase {
         let exp = expectation(description: #function)
 
         // Action
+        // TODO: Replace with ProductDetailRouter
         ProductDetailsFactory.productDetails(product: product,
                                              presentationStyle: .navigationStack,
                                              forceReadOnly: false) { viewController in
@@ -84,6 +88,7 @@ final class ProductDetailsFactoryTests: XCTestCase {
 
         // Action
         waitForExpectation { expectation in
+            // TODO: Replace with ProductDetailRouter
             ProductDetailsFactory.productDetails(product: product,
                                                  presentationStyle: .navigationStack,
                                                  forceReadOnly: false) { viewController in
@@ -100,6 +105,7 @@ final class ProductDetailsFactoryTests: XCTestCase {
 
         // Action
         waitForExpectation { expectation in
+            // TODO: Replace with ProductDetailRouter
             ProductDetailsFactory.productDetails(product: product,
                                                  presentationStyle: .navigationStack,
                                                  forceReadOnly: true) { viewController in

Original file line number	Diff line number	Diff line change
`@@ -189,6 +189,7 @@ private extension ProductStockDashboardCard {`
`189`	`189`	`.product(productID: item.productID)`
`190`	`190`	`}`
`191`	`191`	`}()`
	`192`	`+ // TODO: Replace with ProductDetailRouter`
`192`	`193`	`let loaderViewController = ProductLoaderViewController(model: model,`
`193`	`194`	`siteID: viewModel.siteID,`
`194`	`195`	`forceReadOnly: false)`
Original file line number	Diff line number	Diff line change
`@@ -181,6 +181,7 @@ private extension TopPerformersDashboardView {`
`181`	`181`	`}`
`182`	`182`
`183`	`183`	`func productDetailView(for item: TopEarnerStatsItem) -> UIViewController {`
	`184`	`+ // TODO: Replace with ProductDetailRouter`
`184`	`185`	`let loaderViewController = ProductLoaderViewController(model: .init(topEarnerStatsItem: item),`
`185`	`186`	`siteID: viewModel.siteID,`
`186`	`187`	`forceReadOnly: false)`
Original file line number	Diff line number	Diff line change
`@@ -1036,6 +1036,7 @@ private extension MainTabBarController {`
`1036`	`1036`	`return .productVariation(productID: productID, variationID: variationID)`
`1037`	`1037`	`}`
`1038`	`1038`	`}()`
	`1039`	`+ // TODO: Replace with ProductDetailRouter`
`1039`	`1040`	`let productViewController = ProductLoaderViewController(model: model,`
`1040`	`1041`	`siteID: error.siteID,`
`1041`	`1042`	`forceReadOnly: false)`
Original file line number	Diff line number	Diff line change
`@@ -122,6 +122,7 @@ private extension ProductsSplitViewCoordinator {`
`122`	`122`	`}`
`123`	`123`
`124`	`124`	`func showProductForm(product: Product) {`
	`125`	`+ // TODO: Replace with ProductDetailRouter`
`125`	`126`	`ProductDetailsFactory.productDetails(product: product,`
`126`	`127`	`presentationStyle: .navigationStack,`
`127`	`128`	`forceReadOnly: false,`